Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mdformat #1248

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Feature/mdformat #1248

merged 2 commits into from
Oct 9, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Oct 9, 2024

Describe your changes

Our markdown formatting is inconsistent, this PR adds a formatter.

  • Add mdformat
  • Update make format and make check/format
  • Format repo

Issue ticket number and link

NA

@collindutter collindutter marked this pull request as ready for review October 9, 2024 20:14
vachillo
vachillo previously approved these changes Oct 9, 2024
Copy link
Member

@vachillo vachillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotta get those "lines updated" numbers up somehow

@collindutter
Copy link
Member Author

@vachillo one of the deps was in the wrong poetry group, fixed.

@collindutter collindutter requested a review from vachillo October 9, 2024 20:37
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@collindutter collindutter merged commit 766d365 into dev Oct 9, 2024
15 checks passed
@collindutter collindutter deleted the feature/mdformat branch October 9, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants