-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a rewrite syntax with form \g{n} to allow for integers to follow #463
Conversation
ehhh, sweet! Thanks a lot! Just one question, where does the \g come from? I'm not familiar with it, is it used with sed or something? |
Oh, and since you added tests and all for completeness, could you update the configuration syntax docu too? |
and please add Signed-off-by tag to your commit |
The \g{n} syntax comes from the Backreference section of the libpcre man pages: https://pcre.org/pcre.txt
I'm not tied to it. It was what I found when attempting to solve our problem before realizing that carbon-c-relay doesn't use the regex library to do the substitution. The syntax can be anything that successfully allows the replacement =) |
No this is fine, principle of least surprise I suppose. Please add the docu and Signoff so I can merge, thanks! |
Signed-off-by: Christopher Bowman <cbowman0@gmail.com>
Did I update the carbon-c-relay.md properly? Any feedback on the wording or format? |
can you wrap the doc at at most 80 chars please, apart from that looks perfectly fine to me |
I actually meant only your changes, but this is fine too, thanks! |
Signed-off-by: Fabian Groffen <grobian@gentoo.org>
Here's a proposed solution to fix #462.