Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tags are defined asking interactively for them #30

Merged
merged 5 commits into from
Jan 16, 2022
Merged

Conversation

lucmos
Copy link
Member

@lucmos lucmos commented Jan 12, 2022

No description provided.

@lucmos lucmos requested a review from Flegyas January 12, 2022 21:55
@Flegyas
Copy link
Member

Flegyas commented Jan 13, 2022

I'm not sure about the multi-run setting. What happens if we launch n different runs with no tag set? Are we prompted for all of the tags at once or in between runs?

@lucmos
Copy link
Member Author

lucmos commented Jan 13, 2022

Is there a way to get the information on whether or not we are in multi-run from python? Maybe somewhere from HydraConfig()?

If yes, we could:

  • Raise an error if we are in multi-run and no tags are provided, instead of asking interactively
  • Ask for tags only in job 0, but I think it will be hard to propagate the tags to the other jobs

Moreover, it would be nice to log a common tag between all runs in a multi-run, e.g. multirun-timestamp or multirun-{hash of the options}. This will be probably easier to implement with an interpolation in the configuration

@Flegyas Flegyas merged commit 6cc6302 into develop Jan 16, 2022
@Flegyas Flegyas deleted the feature/tags branch January 16, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants