This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
update filter/sort heading sizes #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgilley
suggested changes
Feb 27, 2017
src/js/components/Filter.js
Outdated
| <Box | ||
| {...boxProps} | ||
| flex={false} | ||
| pad={{...boxProps.pad, ...{between: 'small'}}}> |
There was a problem hiding this comment.
Can this become pad={{...boxProps.pad, between: 'small'}} instead?
update grommet version and fix flex issues with inline filter boxes
michaelgilley
approved these changes
Mar 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates filter/sort headings to be more consistent. Also updated
grommetdependency to 1.2.1 and fixed some flex-shrink issues with inline filters.Codepen
https://codepen.io/nickjvm/pen/vgoPrO?editors=0010
Before
sidebar title ('filter by') and sort label are smaller than state & status filter labels.
After