-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All tokens - Nav menu tweaks #4785
base: master
Are you sure you want to change the base?
Conversation
|
❌ Deploy Preview for rad-shortbread-897892 failed.
|
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
In the |
@@ -50,29 +114,31 @@ export const DesignTokensTable = ({ active, maxHeight, toolbar }) => { | |||
<DataSearch /> | |||
{modeOptions?.length > 1 ? ( | |||
// eslint-disable-next-line grommet/formfield-htmlfor-id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have the htmlFor
on the FormField on my side I didnt see any error here.
position: 'sticky', | ||
top: theme.global.edgeSize.medium, | ||
}} | ||
height="130vh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see why you added this height
but also see an issue this is causing
Deploy Preview
What does this PR do?
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?