Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First version #1

Merged
merged 1 commit into from
Nov 13, 2019
Merged

First version #1

merged 1 commit into from
Nov 13, 2019

Conversation

grongor
Copy link
Owner

@grongor grongor commented Nov 5, 2019

No description provided.

@grongor grongor self-assigned this Nov 5, 2019
@grongor grongor requested a review from simPod November 5, 2019 22:15
simPod
simPod reviewed Nov 5, 2019
View reviewed changes
composer.json Outdated Show resolved Hide resolved
simPod
simPod reviewed Nov 5, 2019
View reviewed changes
Copy link
Collaborator

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1. Moar to come.

phpcs.xml.dist Outdated Show resolved Hide resolved
src/Api/Exception/UnexpectedApiResponse.php Outdated Show resolved Hide resolved
src/Api/Value/Offset.php Outdated Show resolved Hide resolved
src/Api/Value/Partition.php Outdated Show resolved Hide resolved
src/Api/Value/Partition.php Outdated Show resolved Hide resolved
src/Value/Message.php Outdated Show resolved Hide resolved
src/Exception/FailedToProduceMessages.php Show resolved Hide resolved
src/Exception/FailedToProduceMessages.php Show resolved Hide resolved
src/Api/Value/Topic.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
simPod
simPod reviewed Nov 6, 2019
View reviewed changes
Copy link
Collaborator

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NS is too generic, should add vendor prefix 🤔

src/Api/HttpRestClient.php Outdated Show resolved Hide resolved
src/Api/HttpRestClient.php Show resolved Hide resolved
src/Api/HttpRestClient.php Outdated Show resolved Hide resolved
src/Api/HttpRestClient.php Outdated Show resolved Hide resolved
src/Api/HttpRestClient.php Outdated Show resolved Hide resolved
src/Api/HttpRestClient.php Outdated Show resolved Hide resolved
src/Api/RestClient.php Show resolved Hide resolved
src/Api/Value/Request/Message.php Show resolved Hide resolved
src/Api/Value/Response/ProduceResult.php Outdated Show resolved Hide resolved
src/Api/Value/Response/ProduceResult.php Outdated Show resolved Hide resolved
simPod
simPod requested changes Nov 7, 2019
View reviewed changes
Copy link
Collaborator

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small details, lookin good

src/Api/HttpRestClient.php Show resolved Hide resolved
src/Api/Value/Response/Offset.php Show resolved Hide resolved
src/Api/Value/Response/ProduceResult.php Outdated Show resolved Hide resolved
src/Producer.php Show resolved Hide resolved
src/Producer.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/Api/HttpRestClientTest.php Outdated Show resolved Hide resolved
simPod
simPod reviewed Nov 11, 2019
View reviewed changes
src/Api/HttpRestClient.php Outdated Show resolved Hide resolved
src/BatchConsumer.php Show resolved Hide resolved
src/Consumer.php Show resolved Hide resolved
simPod
simPod approved these changes Nov 12, 2019
View reviewed changes
Copy link
Collaborator

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except for those public properties as discussed earlier) !
🚢

@grongor grongor force-pushed the first-version branch 3 times, most recently from 3499a58 to b19433e Compare November 12, 2019 16:32
@grongor grongor merged commit 7bfa051 into master Nov 13, 2019
@grongor grongor deleted the first-version branch November 13, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simPod simPod simPod approved these changes

Assignees

@grongor grongor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grongor @simPod