Document that @steipete's test has turned moot

We don't 100% need to address this now, but we 100% need to remember this in the future.
groue · Apr 10, 2021 · c34615c · c34615c · steipete · Apr 10, 2021
1 parent a5ffc52
commit c34615c
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/Documentation/DemoApps/GRDBCombineDemo/GRDBCombineDemoUITests/GRDBCombineDemoUITests.swift b/Documentation/DemoApps/GRDBCombineDemo/GRDBCombineDemoUITests/GRDBCombineDemoUITests.swift
@@ -26,6 +26,21 @@ class GRDBCombineDemoUITests: XCTestCase {
         return app
     }
 
+    // This test, introduced in 481f6e93, tests the @Query fix added in
+    // 68874412. The fix expresses itself when a view defines an @Query
+    // property that is replaced in the view initializer, as in 481f6e93.
+    //
+    // It happens that I did not find that this particular view setup was suited
+    // for a demo app. The demo has to find a delicate balance, not too trivial,
+    // but without gratuitous complexity.
+    //
+    // I simplified the demo app in a5ffc52d, and we no longer have any view
+    // that defines an @Query property which is replaced in the view
+    // initializer. This means that this test no longer checks against
+    // 68874412 regressions!
+    //
+    // Whenever the @Query property wrapper ships with GRDB itself, make sure
+    // we test for those regressions!
     func testInitialSortingIsByScore() throws {
         let app = runApp()