Skip to content

Commit

Permalink
Remove ill-advised TODO
Browse files Browse the repository at this point in the history
This would force users to force-unwrap their custom `ColumnType(rawValue: "WHATEVER")!`
  • Loading branch information
groue committed Aug 24, 2024
1 parent de96d5f commit c64bc11
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions GRDB/Core/Database.swift
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ public final class Database: CustomStringConvertible, CustomDebugStringConvertib

// MARK: - SQLite C API

// TODO: make it non optional, since one can't get a `Database` instance
// after `close()`.
/// The raw SQLite connection, suitable for the SQLite C API.
///
/// The result is nil after the database has been successfully closed with
Expand Down Expand Up @@ -1923,7 +1921,6 @@ extension Database {
/// The SQL for the column type (`"TEXT"`, `"BLOB"`, etc.)
public let rawValue: String

// TODO: GRDB7 make it an failable initializer that returns nil when rawValue is empty (or blank).
/// Creates an SQL column type.
public init(rawValue: String) {
self.rawValue = rawValue
Expand Down

0 comments on commit c64bc11

Please sign in to comment.