[Feature] Resolvable support #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and accompanying `User#client` property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the codebase for resolvable types to be implemented in node-groupme. See #51 for more info on resolvables.
This PR adds the following properties/methods to
BaseManager:BaseManager<T>#resolve(data: any): T | nullBaseManager<T>#resolveId(data: any): string | nullBaseManager<T>#holds: new (client: Client, ...args: any) => TThe
resolveandresolveIdmethods take a data resolvable and return the resolved data structure. These can be overridden in managers to allow for more powerful and applicable object resolution.The
holdsproperty is the constructor of the type being held by this Manager instance.