Even nicer stringify with less noise #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,6 +76,9 @@ describe 'CSON.stringify', -> | |||
| ] | |||
| } | |||
|
|
|||
| it 'handles NaN as indent', -> | |||
There was a problem hiding this comment.
Did you mean just 'handles NaN', or "... as intended"?
There was a problem hiding this comment.
Good catch, forgot to actually implement that test.
|
Very nice. Handling the spec edge case I initially missed (indent 5.5 => 5, not 0) would be nice, otherwise no strong feeling about the cosmetics. |
|
Addressed the feedback (I think). |
|
Looks great. 🚢 |
jkrems
added a commit
that referenced
this pull request
Dec 5, 2014
Even nicer stringify with less noise
|
v1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9 and to prevent bevry/cson#34 from being a step back.
cc @johan