Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency fix #6

Closed
wants to merge 1 commit into from
Closed

dependency fix #6

wants to merge 1 commit into from

Conversation

etylsarin
Copy link

Dependency declaration changed from git to git+https to prevent using
the git port.
Please, check the issue here: michaelficarra/CoffeeScriptRedux#301

Dependency declaration changed from git to git+https to prevent using
the git port.
@jkrems
Copy link
Contributor

jkrems commented Jun 9, 2014

Hey! Thanks a lot for the contribution! Unfortunately the build fails right now (I'm guessing you are aware of it). Will try to keep an eye open for a beta9 release - in case I miss it: could you just ping this issue once it's released?

@etylsarin
Copy link
Author

Yeah, you're right, I've made the pull request assuming the version is in npm registry already, which is not. Seems like michaelficarra doesn't react too often so I might try to find another way to fix my broken npm install process. Have a good one mate.

@michaelficarra
Copy link

@etylsarin: I am listening, just not interested in doing a version bump for an issue that so few are affected by.

@etylsarin
Copy link
Author

@michaelficarra: ok mate, I'm not sure what is the audience affected by this issue. It might be bigger than you can imagine as the CoffeeScriptRedux is a dependency for quite a few other modules I think and some developers could be dealing with build process issues without letting you know.

@jkrems
Copy link
Contributor

jkrems commented Dec 3, 2014

Resolved by #10.

@jkrems jkrems closed this Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants