insert backslash to double quotes instead of triple quotes #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardtks
force-pushed
the
fix-quadquotes-parse-error
branch
2 times, most recently
from
a71ef2d to
82a7c63
Compare
richardtks
changed the title
|
Hi - thanks for working on this and sorry for the delay. Could you add a test case to make sure we don't introduce regressions in the future? Preferably one that fails without this change but passes when this change is applied. :) |
richardtks
force-pushed
the
fix-quadquotes-parse-error
branch
from
fbe3454 to
b0229a6
Compare
|
@jkrems, I have added the simple test for it. Please review. 😄 |
jkrems
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#75
Motivation
Instead of adding backslash to the first quote, add the backslash to the last quote can solve the problem.