Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port better timeout handling from 2.x #73

Merged
merged 1 commit into from
Dec 5, 2016
Merged

Port better timeout handling from 2.x #73

merged 1 commit into from
Dec 5, 2016

Conversation

jkrems
Copy link
Collaborator

@jkrems jkrems commented Dec 3, 2016 •
edited
Loading

  1. Use setIOTimeout (delay timeout firing to work around event loop lag)
  2. Add completionTimeout support

See: #72
See: #71

dbushong
dbushong approved these changes Dec 5, 2016
View reviewed changes
Copy link
Member

@dbushong dbushong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it

@jkrems jkrems merged commit 599aa30 into 3.x Dec 5, 2016
@jkrems jkrems deleted the jk-3.x-timeouts branch December 5, 2016 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbushong dbushong dbushong approved these changes

Assignees
No one assigned
Labels
semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkrems @dbushong @i-tier-bot