Add a bind_external_framebuffer function to the web sys context
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
expenses
changed the title
bind_raw_framebuffer function to the web sys contextbind_external_framebuffer function to the web sys context
grovesNL
approved these changes
Jun 26, 2022
bors bot
added a commit
that referenced
this pull request
Jun 26, 2022
217: add parallel shader compile extensions r=grovesNL a=xyning used to compile shaders asynchronously to prevent stalls. * webgl: https://www.khronos.org/registry/webgl/extensions/KHR_parallel_shader_compile/ * gl: https://www.khronos.org/registry/OpenGL/extensions/ARB/ARB_parallel_shader_compile.txt * gl & gles: https://www.khronos.org/registry/OpenGL/extensions/KHR/KHR_parallel_shader_compile.txt its still not widely supported however. most real gles devices dont support it, neither does webgl on firefox 218: Add a `bind_external_framebuffer` function to the web sys context r=grovesNL a=expenses This is necessary in order to bind the external framebuffer that you get from WebXR: https://developer.mozilla.org/en-US/docs/Web/API/XRWebGLLayer/framebuffer I'm using this for my branch of wgpu that can render to WebXR framebuffers: gfx-rs/wgpu@master...expenses:webxr Co-authored-by: Lictex Steaven <lictex_steaven@outlook.com> Co-authored-by: Ashley Ruglys <ashley.ruglys@gmail.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Jun 26, 2022
218: Add a `bind_external_framebuffer` function to the web sys context r=grovesNL a=expenses This is necessary in order to bind the external framebuffer that you get from WebXR: https://developer.mozilla.org/en-US/docs/Web/API/XRWebGLLayer/framebuffer I'm using this for my branch of wgpu that can render to WebXR framebuffers: gfx-rs/wgpu@master...expenses:webxr Co-authored-by: Ashley Ruglys <ashley.ruglys@gmail.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in order to bind the external framebuffer that you get from WebXR: https://developer.mozilla.org/en-US/docs/Web/API/XRWebGLLayer/framebuffer
I'm using this for my branch of wgpu that can render to WebXR framebuffers: gfx-rs/wgpu@master...expenses:webxr