Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to monorepo, add remote eval #33

Merged
merged 28 commits into from
Oct 9, 2023
Merged

Conversation

bryce-fitzsimons
Copy link
Member

@bryce-fitzsimons bryce-fitzsimons commented Sep 19, 2023

Convert to monorepo, add remote evaluation support:

  • Separate out the proxy app to its own package
  • Create a new remote evaluation package
  • Publish all packages independently to NPM
  • Fix several security vulnerabilities
  • Require Node 18+
  • Bump proxy's minor version number

@bryce-fitzsimons bryce-fitzsimons marked this pull request as ready for review October 4, 2023 22:33
evaluatedFeatures[key].rules = [
{
force: result.value,
tracks: [{ experiment: result.experiment, result }],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sending the full experiment object down, including variations that were not assigned. Do we want to do the same filtering we're doing below to remove that info?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added filtering

@bryce-fitzsimons bryce-fitzsimons merged commit 9fc711c into main Oct 9, 2023
1 check passed
@bryce-fitzsimons bryce-fitzsimons deleted the convert-to-monorepo branch October 9, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants