-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to monorepo, add remote eval #33
Conversation
packages/apps/proxy/src/middleware/cache/readThroughCacheMiddleware.ts
Outdated
Show resolved
Hide resolved
packages/shared/eval/src/index.ts
Outdated
evaluatedFeatures[key].rules = [ | ||
{ | ||
force: result.value, | ||
tracks: [{ experiment: result.experiment, result }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is sending the full experiment object down, including variations that were not assigned. Do we want to do the same filtering we're doing below to remove that info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added filtering
Convert to monorepo, add remote evaluation support: