When feature's default value is false it returns nil instead

[pokonski]

Given a super simple feature defition:

{"defaultValue"=>false}

The SDK returns nil when checking its value, reproduction code:

features = {"simple_feature" => {"defaultValue" => false}}
gb = Growthbook::Context.new(features: features)
gb.on?("simple_feature") #=> false
gb.feature_value("simple_feature") #=> nil

Is this expected behaviour? The offending code is here: https://github.com/growthbook/growthbook-ruby/blob/main/lib/growthbook/context.rb#L137

Which I think is incorrect since: false || nil in Ruby will always yield nil. I think what author meant to write was:

feature.default_value.nil? ? nil : feature.default_value

---

I also tested the behaviour with JS SDK and it does return false as expected:

gb.loadFeatures({ autoRefresh: true }).then(function() {
	gb.getFeatureValue('simple_feature'); // => false
});

[pokonski]

I can provide a PR with a fix if needed and you confirm this to be an issue :)

[jdorn]

Thanks for catching this. A PR would be great!

[Rabshab]

PR here