Make $in and $nin work with arrays
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinahollygb
reviewed
Jul 31, 2023
| def self.is_in?(actual, expected) | ||
| return expected.include?(actual) unless actual.is_a? Array | ||
|
|
||
| def self.in?(actual, expected) |
There was a problem hiding this comment.
I think we may be missing a type definition in the .rbs file for this.
There was a problem hiding this comment.
Done eaf3842, @tinahollygb 😸
|
Are we missing something else here, @tinahollygb? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22 but fixing the existing style issues
Similar to growthbook/growthbook#1246, trying to have the same behavior and the latest features in this SDK.