Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1: Switch from github.com/go-kit/kit to github.com/go-kit/log interfaces #426

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 15, 2021

github.com/go-kit/kit split out just the logging interfaces to github.com/go-kit/log to allow downstreams to avoid inheriting large numbers of additional dependencies (made visible and impacting to go modules in v0.10.0 of github.com/go-kit/kit). xref prometheus/common#255

This switches to the slimmed down logging interface module to avoid a bump to go-kit/kit v0.10.0 picking up a ton of new dependencies

v2 version in #426

cc @dims

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #426 (c685ed1) into master (6465c16) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #426   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files          42       42           
  Lines        1370     1370           
=======================================
  Hits         1003     1003           
  Misses        306      306           
  Partials       61       61           
Impacted Files Coverage Δ
logging/kit/client_interceptors.go 100.00% <ø> (ø)
logging/kit/ctxkit/context.go 0.00% <ø> (ø)
logging/kit/options.go 80.48% <ø> (ø)
logging/kit/payload_interceptors.go 78.57% <ø> (ø)
logging/kit/server_interceptors.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6465c16...c685ed1. Read the comment docs.

@dims
Copy link

dims commented Jun 15, 2021

details go-kit/kit#1055 and prometheus/common#255

@liggitt liggitt changed the title Switch from github.com/go-kit/kit to github.com/go-kit/log interfaces v1: Switch from github.com/go-kit/kit to github.com/go-kit/log interfaces Jun 15, 2021
@liggitt
Copy link
Contributor Author

liggitt commented Jun 15, 2021

cc @johanbrandhorst

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small nit

README.md Outdated Show resolved Hide resolved
@liggitt
Copy link
Contributor Author

liggitt commented Jun 16, 2021

done

@johanbrandhorst johanbrandhorst merged commit a63f4c4 into grpc-ecosystem:master Jun 18, 2021
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants