v2:interceptors/logging: allow to separate request response payload logging #442

michaljemala · 2021-07-13T22:11:47Z

Logging payloads of requests on the server-side and similarly of responses on the client-side is a pretty common and desired use-case. However, logging by default payloads of both requests as well as responses in both scenarios is IMO not a very common requirement.

Consider the following PR to enable more granular control of what to log and when. This is achieved by using a special PayloadDecison type having the following values:

NoPayloadLogging - Payload logging is disabled.
LogRequest - Only logging of requests is enabled.
LogResponse - Only logging of responses is enabled.
LogRequestAndResponse - Logging of both requests and responses is enabled.
The PayloadDecison is to be used instead of the original bool by the logging.ServerPayloadLoggingDecider and logging.ClientPayloadLoggingDecider.

NOTE: I quickly put this together to see whether it could be considered a valid approach, thus please excuse the lack of additional unit tests. I will be glad to add those once the approach is approved.

google-cla · 2021-07-13T22:11:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

michaljemala · 2021-07-13T22:15:22Z

@googlebot I fixed it.

google-cla · 2021-07-13T22:15:25Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

michaljemala · 2021-07-13T22:18:03Z

@googlebot I fixed it.

codecov-commenter · 2021-07-14T00:37:38Z

Codecov Report

Merging #442 (e75d159) into v2 (6e2c2ac) will decrease coverage by 25.51%.
The diff coverage is 42.66%.

❗ Current head e75d159 differs from pull request most recent head 9f260f9. Consider uploading reports for the commit 9f260f9 to get more accurate results

@@             Coverage Diff             @@
##               v2     #442       +/-   ##
===========================================
- Coverage   84.01%   58.49%   -25.52%     
===========================================
  Files          30       38        +8     
  Lines         932     1706      +774     
===========================================
+ Hits          783      998      +215     
- Misses        110      636      +526     
- Partials       39       72       +33

Impacted Files	Coverage Δ
chain.go	`0.00% <ø> (-90.91%)`	⬇️
interceptors/auth/auth.go	`100.00% <ø> (ø)`
interceptors/auth/metadata.go	`100.00% <ø> (ø)`
interceptors/logging/options.go	`82.85% <0.00%> (-7.77%)`	⬇️
interceptors/ratelimit/ratelimit.go	`60.00% <0.00%> (-40.00%)`	⬇️
interceptors/recovery/options.go	`78.57% <ø> (ø)`
interceptors/retry/backoff.go	`52.94% <ø> (+2.94%)`	⬆️
interceptors/tags/context.go	`64.00% <ø> (ø)`
interceptors/tags/fieldextractor.go	`15.15% <0.00%> (-70.15%)`	⬇️
interceptors/tags/interceptors.go	`95.65% <ø> (ø)`
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc87da6...9f260f9. Read the comment docs.

johanbrandhorst

I quite like this, but it was @bwplotka who refactored these, so I would prefer to have his input.

yashrsharma44

Functionally - I think using a switch case would make this code easier to read and maintainable. Otherwise looks good to me!

interceptors/logging/payload.go

yashrsharma44 · 2021-08-02T17:06:46Z

Hi @michaljemala !

This PR looks good to me, can you run make lint for fixing the CI changes required?
Otherwise looks good to me.

yashrsharma44 · 2021-08-02T17:07:24Z

cc'ing @bwplotka for the inputs 😄

yashrsharma44 · 2021-08-03T06:46:11Z

Seems like the CI build needs approval for first time contributors - https://github.blog/changelog/2021-04-22-github-actions-maintainers-must-approve-first-time-contributor-workflow-runs/

michaljemala · 2021-08-05T09:30:11Z

Hi @yashrsharma44 is there anything else on my side to be done?

yashrsharma44 · 2021-08-05T12:01:08Z

We are blocked on @bwplotka's review. Let me get back to him when he is free.

bwplotka

LGTM, only minor nit and lint error 🤗

Thanks!

bwplotka · 2021-08-06T06:14:27Z

interceptors/logging/logging.go

+	// NoPayloadLogging - Payload logging is disabled.
+	NoPayloadLogging PayloadDecision = iota
+	// LogRequest - Only logging of requests is enabled.
+	LogRequest


Suggested change

LogRequest

LogPayloadRequest

bwplotka · 2021-08-06T06:14:34Z

interceptors/logging/logging.go

+	// LogRequest - Only logging of requests is enabled.
+	LogRequest
+	// LogResponse - Only logging of responses is enabled.
+	LogResponse


Suggested change

LogResponse

LogPayloadResponse

bwplotka · 2021-08-06T06:14:45Z

interceptors/logging/logging.go

+	// LogResponse - Only logging of responses is enabled.
+	LogResponse
+	// LogRequestAndResponse - Logging of both requests and responses is enabled.
+	LogRequestAndResponse


Suggested change

LogRequestAndResponse

LogPayloadRequestAndResponse

…ponse payload logging

bwplotka

Thanks!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/grpc-ecosystem/go-grpc-middleware](https://github.com/grpc-ecosystem/go-grpc-middleware) | `v1.4.0` -> `v2.1.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgrpc-ecosystem%2fgo-grpc-middleware/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgrpc-ecosystem%2fgo-grpc-middleware/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgrpc-ecosystem%2fgo-grpc-middleware/v1.4.0/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgrpc-ecosystem%2fgo-grpc-middleware/v1.4.0/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc-ecosystem/go-grpc-middleware (github.com/grpc-ecosystem/go-grpc-middleware)</summary> ### [`v2.1.0`](https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.1.0) [Compare Source](https://github.com/grpc-ecosystem/go-grpc-middleware/compare/v2.0.1...v2.1.0) #### What's Changed - Support for subsystem in grpc prometheus counter and histogram metrics by [@rohsaini](https://github.com/rohsaini) in [grpc-ecosystem/go-grpc-middleware#643 - doc: update client interceptors chaining example with grpc functions by [@dethi](https://github.com/dethi) in [grpc-ecosystem/go-grpc-middleware#669 - adds fields from durationFieldFunc to request/response log entries by [@vroldanbet](https://github.com/vroldanbet) in [grpc-ecosystem/go-grpc-middleware#670 - add doc for disabling log opts by [@coleenquadros](https://github.com/coleenquadros) in [grpc-ecosystem/go-grpc-middleware#680 - Middleware for determining the real ip of the client by [@MadsRC](https://github.com/MadsRC) in [grpc-ecosystem/go-grpc-middleware#682 - protovalidate: add option to ignore certain message types by [@igor-tsiglyar](https://github.com/igor-tsiglyar) in [grpc-ecosystem/go-grpc-middleware#684 - Update README.md by [@zeroboo](https://github.com/zeroboo) in [grpc-ecosystem/go-grpc-middleware#688 - Fix `InitializeMetrics` signature to allow use with `xds.GRPCServer` by [@bozaro](https://github.com/bozaro) in [grpc-ecosystem/go-grpc-middleware#689 - Support retriable func condition by [@tamayika](https://github.com/tamayika) in [grpc-ecosystem/go-grpc-middleware#687 - Extend realip parsing of GRPC peer address to handle IPv6 by [@surik](https://github.com/surik) in [grpc-ecosystem/go-grpc-middleware#692 - Fix logging Example : log only first field by [@arckadious](https://github.com/arckadious) in [grpc-ecosystem/go-grpc-middleware#694 - Extent realip interceptors with ip selection based on proxy count and list by [@surik](https://github.com/surik) in [grpc-ecosystem/go-grpc-middleware#695 - Fix for vulnerability CVE-2023-44487 by [@vkaushik](https://github.com/vkaushik) in [grpc-ecosystem/go-grpc-middleware#696 #### New Contributors - [@rohsaini](https://github.com/rohsaini) made their first contribution in [grpc-ecosystem/go-grpc-middleware#643 - [@dethi](https://github.com/dethi) made their first contribution in [grpc-ecosystem/go-grpc-middleware#669 - [@vroldanbet](https://github.com/vroldanbet) made their first contribution in [grpc-ecosystem/go-grpc-middleware#670 - [@MadsRC](https://github.com/MadsRC) made their first contribution in [grpc-ecosystem/go-grpc-middleware#682 - [@igor-tsiglyar](https://github.com/igor-tsiglyar) made their first contribution in [grpc-ecosystem/go-grpc-middleware#684 - [@zeroboo](https://github.com/zeroboo) made their first contribution in [grpc-ecosystem/go-grpc-middleware#688 - [@bozaro](https://github.com/bozaro) made their first contribution in [grpc-ecosystem/go-grpc-middleware#689 - [@tamayika](https://github.com/tamayika) made their first contribution in [grpc-ecosystem/go-grpc-middleware#687 - [@surik](https://github.com/surik) made their first contribution in [grpc-ecosystem/go-grpc-middleware#692 - [@arckadious](https://github.com/arckadious) made their first contribution in [grpc-ecosystem/go-grpc-middleware#694 - [@vkaushik](https://github.com/vkaushik) made their first contribution in [grpc-ecosystem/go-grpc-middleware#696 **Full Changelog**: grpc-ecosystem/go-grpc-middleware@v2.0.1...v2.1.0 ### [`v2.0.1`](https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.1) [Compare Source](https://github.com/grpc-ecosystem/go-grpc-middleware/compare/v2.0.0...v2.0.1) #### What's Changed - Fix outdated 'make proto' command by [@takp](https://github.com/takp) in [grpc-ecosystem/go-grpc-middleware#623 - Fix linting errors by [@takp](https://github.com/takp) in [grpc-ecosystem/go-grpc-middleware#624 - Logging: Add missing variadic operator for fields by [@olivierlemasle](https://github.com/olivierlemasle) in [grpc-ecosystem/go-grpc-middleware#629 - feat: Support extracting fields from CallMeta by [@fsaintjacques](https://github.com/fsaintjacques) in [grpc-ecosystem/go-grpc-middleware#628 - Fix "make test" and "make lint" by [@olivierlemasle](https://github.com/olivierlemasle) in [grpc-ecosystem/go-grpc-middleware#627 - Do not set timeout for stream initialization by [@DavyJohnes](https://github.com/DavyJohnes) in [grpc-ecosystem/go-grpc-middleware#645 - Add logging option to disable fields in log entry by [@coleenquadros](https://github.com/coleenquadros) in [grpc-ecosystem/go-grpc-middleware#631 - Update logging adapter docs by [@aboryslawski](https://github.com/aboryslawski) in [grpc-ecosystem/go-grpc-middleware#647 #### New Contributors - [@takp](https://github.com/takp) made their first contribution in [grpc-ecosystem/go-grpc-middleware#623 - [@olivierlemasle](https://github.com/olivierlemasle) made their first contribution in [grpc-ecosystem/go-grpc-middleware#629 - [@fsaintjacques](https://github.com/fsaintjacques) made their first contribution in [grpc-ecosystem/go-grpc-middleware#628 - [@DavyJohnes](https://github.com/DavyJohnes) made their first contribution in [grpc-ecosystem/go-grpc-middleware#645 - [@coleenquadros](https://github.com/coleenquadros) made their first contribution in [grpc-ecosystem/go-grpc-middleware#631 - [@aboryslawski](https://github.com/aboryslawski) made their first contribution in [grpc-ecosystem/go-grpc-middleware#647 **Full Changelog**: grpc-ecosystem/go-grpc-middleware@v2.0.0...v2.0.1 ### [`v2.0.0`](https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.0) [Compare Source](https://github.com/grpc-ecosystem/go-grpc-middleware/compare/v1.4.0...v2.0.0) This is the first stable release of the new v2 release branch 🎉 Many of the interceptors have been rewritten from scratch and the project has been upgraded to use the Go Protobuf v2 API. See the project README for details and migration guide. Thanks to all contributors who made this possible! 💪🏽 #### What's Changed - Initial change for v2. by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#276 - Updated README with note that it's under development. by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#278 - Fix typo in field extractor (splices -> slices) ([#287](https://github.com/grpc-ecosystem/go-grpc-middleware/issues/287)) by [@bvwells](https://github.com/bvwells) in [grpc-ecosystem/go-grpc-middleware#289 - Moved imports to v2; Moved to Go 1.14.2 by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#290 - Formatted code; Added goimports to Makefile, Renamed pb_testproto to testpb. by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#291 - Fixed providers go modules, examples and consistency. by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#292 - added example for AuthFuncOverride v2 branch by [@tegk](https://github.com/tegk) in [grpc-ecosystem/go-grpc-middleware#294 - Added some description of the Makefile in the contributing.md by [@yashrsharma44](https://github.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#298 - v2: Add support for the zerolog logging provider by [@irridia](https://github.com/irridia) in [grpc-ecosystem/go-grpc-middleware#299 - proto: fix gogoproto import by [@johanbrandhorst](https://github.com/johanbrandhorst) in [grpc-ecosystem/go-grpc-middleware#302 - Retry dial and connection errors for grpc stream. by [@kartlee](https://github.com/kartlee) in [grpc-ecosystem/go-grpc-middleware#308 - Moved to GH actions; Added lint; Added issue/PR templates. by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#296 - inline localhost certificate into go file by [@bmon](https://github.com/bmon) in [grpc-ecosystem/go-grpc-middleware#318 - Update streaming interceptor example by [@G07cha](https://github.com/G07cha) in [grpc-ecosystem/go-grpc-middleware#322 - Do not stop retrying based on earlier good message from the stream by [@kartlee](https://github.com/kartlee) in [grpc-ecosystem/go-grpc-middleware#323 - test certs - cherry-pick PR325 on v2 by [@dmitris](https://github.com/dmitris) in [grpc-ecosystem/go-grpc-middleware#331 - add all make target, reword instructions by [@dmitris](https://github.com/dmitris) in [grpc-ecosystem/go-grpc-middleware#335 - remove 1.12.x from build config for consistency with master by [@dmitris](https://github.com/dmitris) in [grpc-ecosystem/go-grpc-middleware#337 - \[v2] Fix the special case for jaeger format traceid extraction by [@nvx](https://github.com/nvx) in [grpc-ecosystem/go-grpc-middleware#340 - \[v2] Fix ctxtags TagBasedRequestFieldExtractor extracting from fields in a oneof by [@nvx](https://github.com/nvx) in [grpc-ecosystem/go-grpc-middleware#339 - Request Logging by [@yashrsharma44](https://github.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#311 - Bug fix for data race by [@yashrsharma44](https://github.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#354 - make ratelimit interface context aware by [@xinxiao](https://github.com/xinxiao) in [grpc-ecosystem/go-grpc-middleware#367 - Add error param to the decider method of logging middleware by [@yashrsharma44](https://github.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#372 - \[v2] Add skip interceptor by [@XSAM](https://github.com/XSAM) in [grpc-ecosystem/go-grpc-middleware#364 - Chain middleware by [@drewwells](https://github.com/drewwells) in [grpc-ecosystem/go-grpc-middleware#385 - Update travis ci badget to Github actions badge. by [@drewwells](https://github.com/drewwells) in [grpc-ecosystem/go-grpc-middleware#384 - Upgraded proto related deps: grpc and protobuf; removed gogo from core. by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#321 - improve v2 rate-limiter by [@MalloZup](https://github.com/MalloZup) in [grpc-ecosystem/go-grpc-middleware#380 - Moved to buf; Added buf lint; Fixed ping service to match standards; … by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#383 - Add timer interface for OpenMetrics(Prometheus) Provider by [@yashrsharma44](https://github.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#387 - \[Rate-limit provider]: Add token bucket implementation of rate-limiter by [@MalloZup](https://github.com/MalloZup) in [grpc-ecosystem/go-grpc-middleware#386 - Add OpenMetrics(Prometheus) in the provider module by [@yashrsharma44](https://github.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#379 - v2: Client unary interceptor timeout on v2 branch by [@instabledesign](https://github.com/instabledesign) in [grpc-ecosystem/go-grpc-middleware#330 - add onRetryCallback callback function by [@shamil](https://github.com/shamil) in [grpc-ecosystem/go-grpc-middleware#405 - v2: validator support for protoc-gen-validate 0.6.0 by [@danielhochman](https://github.com/danielhochman) in [grpc-ecosystem/go-grpc-middleware#418 - v2: Refactor metrics interceptor and fix tests by [@ash2k](https://github.com/ash2k) in [grpc-ecosystem/go-grpc-middleware#413 - Support customization of timestamp format (v2 branch) by [@stanhu](https://github.com/stanhu) in [grpc-ecosystem/go-grpc-middleware#399 - Fixed misleading comments in the interceptor file by [@iamrajiv](https://github.com/iamrajiv) in [grpc-ecosystem/go-grpc-middleware#424 - v2: Switch from github.com/go-kit/kit to github.com/go-kit/log interfaces by [@liggitt](https://github.com/liggitt) in [grpc-ecosystem/go-grpc-middleware#427 - v2: Add support for the phuslog logging provider by [@ogimenezb](https://github.com/ogimenezb) in [grpc-ecosystem/go-grpc-middleware#425 - v2:providers/zap: fix caller annotation by [@jkawamoto](https://github.com/jkawamoto) in [grpc-ecosystem/go-grpc-middleware#432 - Added Dependabot by [@iamrajiv](https://github.com/iamrajiv) in [grpc-ecosystem/go-grpc-middleware#376 - Added a Copyright check in the Makefile by [@yashrsharma44](https://github.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#420 - Cleanup v2 with some updates by [@yashrsharma44](https://github.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#419 - openmetrics: forward server context by [@amenzhinsky](https://github.com/amenzhinsky) in [grpc-ecosystem/go-grpc-middleware#434 - recovery: change the default behavior by [@amenzhinsky](https://github.com/amenzhinsky) in [grpc-ecosystem/go-grpc-middleware#439 - Add all-validator support by [@leventeliu](https://github.com/leventeliu) in [grpc-ecosystem/go-grpc-middleware#443 - Remove backoffutils and added the files to retry package by [@yashrsharma44](https://github.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#390 - v2:interceptors/logging: allow to separate request response payload logging by [@michaljemala](https://github.com/michaljemala) in [grpc-ecosystem/go-grpc-middleware#442 - Removed tags; Simplified interceptor code; Added logging fields editability. by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#394 - InterceptorTestSuite client connection optimize by [@HUSTtoKTH](https://github.com/HUSTtoKTH) in [grpc-ecosystem/go-grpc-middleware#455 - Remove opentracing from go.mod by [@jpkrohling](https://github.com/jpkrohling) in [grpc-ecosystem/go-grpc-middleware#477 - Replace two old Go versions with two new ones by [@jpkrohling](https://github.com/jpkrohling) in [grpc-ecosystem/go-grpc-middleware#478 - Move util/metautils to root-level package metadata, fixes [#392](https://github.com/grpc-ecosystem/go-grpc-middleware/issues/392) by [@rahulkhairwar](https://github.com/rahulkhairwar) in [grpc-ecosystem/go-grpc-middleware#474 - Remove data race from zerolog provider by [@ecordell](https://github.com/ecordell) in [grpc-ecosystem/go-grpc-middleware#487 - Update provider/kit by [@metalmatze](https://github.com/metalmatze) in [grpc-ecosystem/go-grpc-middleware#490 - Refactor tracing interceptor by [@XSAM](https://github.com/XSAM) in [grpc-ecosystem/go-grpc-middleware#450 - Add opentracing provider by [@XSAM](https://github.com/XSAM) in [grpc-ecosystem/go-grpc-middleware#492 - update phuslog to fix typo by [@ogimenezb](https://github.com/ogimenezb) in [grpc-ecosystem/go-grpc-middleware#499 - Added logr as logging Library provider by [@mcdoker18](https://github.com/mcdoker18) in [grpc-ecosystem/go-grpc-middleware#510 - ✨ new feat: selector middleware by [@aimuz](https://github.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#511 - Add 1.18.x and 1.19.x unit tests by [@aimuz](https://github.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#513 - change the doc.go to the latest format by [@aimuz](https://github.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#512 - fix provider examples by [@forsaken628](https://github.com/forsaken628) in [grpc-ecosystem/go-grpc-middleware#529 - docs: add `logging.InjectFields` usage description by [@aimuz](https://github.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#541 - Bump golang.org/x/net from 0.0.0-20201021035429-f5854403a974 to 0.7.0 by [@dependabot](https://github.com/dependabot) in [grpc-ecosystem/go-grpc-middleware#537 - v2: All for v2: Exemplars, Cleanup, Docs, Lint, Proto upgrades and more by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#543 - \[interceptors/validator] feat: add error logging in validator by [@rohanraj7316](https://github.com/rohanraj7316) in [grpc-ecosystem/go-grpc-middleware#544 - fix auto-generated docs by [@peczenyj](https://github.com/peczenyj) in [grpc-ecosystem/go-grpc-middleware#548 - fix vulnerability GO-2022-0603 by [@peczenyj](https://github.com/peczenyj) in [grpc-ecosystem/go-grpc-middleware#549 - add support to trace on grpc_logrus.DefaultMessageProducer by [@peczenyj](https://github.com/peczenyj) in [grpc-ecosystem/go-grpc-middleware#547 - Simplified logging middleware; Fields are now "any" type; Moved logging providers to examples only. by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#552 - Removed deciders; Cleaned up validators. by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#554 - Adjustments to README and consistency of callback options. by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#555 - Merge v2 into main (with -X theirs) by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#556 - Bump golang.org/x/net from 0.5.0 to 0.7.0 in /providers/prometheus by [@dependabot](https://github.com/dependabot) in [grpc-ecosystem/go-grpc-middleware#561 - Fix overwritten logger in zerolog example by [@longshine](https://github.com/longshine) in [grpc-ecosystem/go-grpc-middleware#574 - Changed for for mapping fields, different var for logger in zap example by [@MichalFikejs](https://github.com/MichalFikejs) in [grpc-ecosystem/go-grpc-middleware#581 - cleanup: no cap definition required by [@aimuz](https://github.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#582 - providers/prometheus: Add WithHistogramOpts for native histograms by [@metalmatze](https://github.com/metalmatze) in [grpc-ecosystem/go-grpc-middleware#584 - fix: Refactor logger initialization in example_test.go by [@aimuz](https://github.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#580 - Minor code cleanups by [@ash2k](https://github.com/ash2k) in [grpc-ecosystem/go-grpc-middleware#586 - fix prometheus interceptors not converting context errors to gRPC codes by [@vtermanis](https://github.com/vtermanis) in [grpc-ecosystem/go-grpc-middleware#571 - Update README.md by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#600 - Update PULL_REQUEST_TEMPLATE.md by [@bwplotka](https://github.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#601 - Add Client rate limit interceptors 520 by [@rahulkhairwar](https://github.com/rahulkhairwar) in [grpc-ecosystem/go-grpc-middleware#599 - Use default go errors package instead of github.com/pkg/errors by [@rifkyazizf](https://github.com/rifkyazizf) in [grpc-ecosystem/go-grpc-middleware#608 - fix bug : should drain channel of timer after stop by [@ikenchina](https://github.com/ikenchina) in [grpc-ecosystem/go-grpc-middleware#612 - feat: add interceptor for bufbuild/protovalidate by [@gvencadze](https://github.com/gvencadze) in [grpc-ecosystem/go-grpc-middleware#614 - Enhancement: Introduce Option Interface for Future Interceptor Customization by [@elliotmjackson](https://github.com/elliotmjackson) in [grpc-ecosystem/go-grpc-middleware#615 #### New Contributors - [@irridia](https://github.com/irridia) made their first contribution in [grpc-ecosystem/go-grpc-middleware#299 - [@xinxiao](https://github.com/xinxiao) made their first contribution in [grpc-ecosystem/go-grpc-middleware#367 - [@XSAM](https://github.com/XSAM) made their first contribution in [grpc-ecosystem/go-grpc-middleware#364 - [@MalloZup](https://github.com/MalloZup) made their first contribution in [grpc-ecosystem/go-grpc-middleware#380 - [@instabledesign](https://github.com/instabledesign) made their first contribution in [grpc-ecosystem/go-grpc-middleware#330 - [@shamil](https://github.com/shamil) made their first contribution in [grpc-ecosystem/go-grpc-middleware#405 - [@ash2k](https://github.com/ash2k) made their first contribution in [grpc-ecosystem/go-grpc-middleware#413 - [@ogimenezb](https://github.com/ogimenezb) made their first contribution in [grpc-ecosystem/go-grpc-middleware#425 - [@amenzhinsky](https://github.com/amenzhinsky) made their first contribution in [grpc-ecosystem/go-grpc-middleware#434 - [@leventeliu](https://github.com/leventeliu) made their first contribution in [grpc-ecosystem/go-grpc-middleware#443 - [@michaljemala](https://github.com/michaljemala) made their first contribution in [grpc-ecosystem/go-grpc-middleware#442 - [@HUSTtoKTH](https://github.com/HUSTtoKTH) made their first contribution in [grpc-ecosystem/go-grpc-middleware#455 - [@jpkrohling](https://github.com/jpkrohling) made their first contribution in [grpc-ecosystem/go-grpc-middleware#477 - [@rahulkhairwar](https://github.com/rahulkhairwar) made their first contribution in [grpc-ecosystem/go-grpc-middleware#474 - [@ecordell](https://github.com/ecordell) made their first contribution in [grpc-ecosystem/go-grpc-middleware#487 - [@metalmatze](https://github.com/metalmatze) made their first contribution in [grpc-ecosystem/go-grpc-middleware#490 - [@mcdoker18](https://github.com/mcdoker18) made their first contribution in [grpc-ecosystem/go-grpc-middleware#510 - [@aimuz](https://github.com/aimuz) made their first contribution in [grpc-ecosystem/go-grpc-middleware#511 - [@forsaken628](https://github.com/forsaken628) made their first contribution in [grpc-ecosystem/go-grpc-middleware#529 - [@dependabot](https://github.com/dependabot) made their first contribution in [grpc-ecosystem/go-grpc-middleware#537 - [@rohanraj7316](https://github.com/rohanraj7316) made their first contribution in [grpc-ecosystem/go-grpc-middleware#544 - [@peczenyj](https://github.com/peczenyj) made their first contribution in [grpc-ecosystem/go-grpc-middleware#548 - [@longshine](https://github.com/longshine) made their first contribution in [grpc-ecosystem/go-grpc-middleware#574 - [@MichalFikejs](https://github.com/MichalFikejs) made their first contribution in [grpc-ecosystem/go-grpc-middleware#581 - [@vtermanis](https://github.com/vtermanis) made their first contribution in [grpc-ecosystem/go-grpc-middleware#571 - [@rifkyazizf](https://github.com/rifkyazizf) made their first contribution in [grpc-ecosystem/go-grpc-middleware#608 - [@ikenchina](https://github.com/ikenchina) made their first contribution in [grpc-ecosystem/go-grpc-middleware#612 - [@gvencadze](https://github.com/gvencadze) made their first contribution in [grpc-ecosystem/go-grpc-middleware#614 - [@elliotmjackson](https://github.com/elliotmjackson) made their first contribution in [grpc-ecosystem/go-grpc-middleware#615 **Full Changelog**: grpc-ecosystem/go-grpc-middleware@v1.4.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jaegertracing/jaeger).  --------- Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Yuri Shkuro <github@ysh.us>

michaljemala force-pushed the v2_separate_request_response_payload_logs branch from 1c3e861 to 5bcaa5b Compare July 13, 2021 22:17

michaljemala force-pushed the v2_separate_request_response_payload_logs branch from 5bcaa5b to ebc4206 Compare July 13, 2021 22:22

johanbrandhorst reviewed Jul 14, 2021

View reviewed changes

yashrsharma44 requested changes Jul 14, 2021

View reviewed changes

interceptors/logging/payload.go Outdated Show resolved Hide resolved

yashrsharma44 added the v2 label Jul 14, 2021

yashrsharma44 mentioned this pull request Jul 14, 2021

For Payload Logging Interceptors, consider allowing deciding on both request and response #400

Closed

yashrsharma44 linked an issue Jul 14, 2021 that may be closed by this pull request

For Payload Logging Interceptors, consider allowing deciding on both request and response #400

Closed

michaljemala force-pushed the v2_separate_request_response_payload_logs branch from ebc4206 to e0ec88c Compare July 14, 2021 19:45

michaljemala force-pushed the v2_separate_request_response_payload_logs branch 3 times, most recently from 685607e to e75d159 Compare August 3, 2021 06:29

yashrsharma44 approved these changes Aug 5, 2021

View reviewed changes

bwplotka approved these changes Aug 6, 2021

View reviewed changes

v2:interceptors/logging: add payload decision to separate request res…

9f260f9

…ponse payload logging

michaljemala force-pushed the v2_separate_request_response_payload_logs branch from e75d159 to 9f260f9 Compare August 7, 2021 07:29

bwplotka approved these changes Aug 7, 2021

View reviewed changes

bwplotka merged commit 274df59 into grpc-ecosystem:v2 Aug 7, 2021

aimuz mentioned this pull request Mar 8, 2023

docs: add logging.InjectFields usage description #540

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v2:interceptors/logging: allow to separate request response payload logging #442

v2:interceptors/logging: allow to separate request response payload logging #442

michaljemala commented Jul 13, 2021 •

edited

Loading

google-cla bot commented Jul 13, 2021

michaljemala commented Jul 13, 2021

google-cla bot commented Jul 13, 2021

michaljemala commented Jul 13, 2021

codecov-commenter commented Jul 14, 2021 •

edited

Loading

johanbrandhorst left a comment

yashrsharma44 left a comment

yashrsharma44 commented Aug 2, 2021

yashrsharma44 commented Aug 2, 2021

yashrsharma44 commented Aug 3, 2021

michaljemala commented Aug 5, 2021

yashrsharma44 commented Aug 5, 2021

bwplotka left a comment

bwplotka Aug 6, 2021

michaljemala Aug 7, 2021

bwplotka Aug 6, 2021

michaljemala Aug 7, 2021

bwplotka Aug 6, 2021

michaljemala Aug 7, 2021

bwplotka left a comment

v2:interceptors/logging: allow to separate request response payload logging #442

v2:interceptors/logging: allow to separate request response payload logging #442

Conversation

michaljemala commented Jul 13, 2021 • edited Loading

google-cla bot commented Jul 13, 2021

michaljemala commented Jul 13, 2021

google-cla bot commented Jul 13, 2021

michaljemala commented Jul 13, 2021

codecov-commenter commented Jul 14, 2021 • edited Loading

Codecov Report

johanbrandhorst left a comment

Choose a reason for hiding this comment

yashrsharma44 left a comment

Choose a reason for hiding this comment

yashrsharma44 commented Aug 2, 2021

yashrsharma44 commented Aug 2, 2021

yashrsharma44 commented Aug 3, 2021

michaljemala commented Aug 5, 2021

yashrsharma44 commented Aug 5, 2021

bwplotka left a comment

Choose a reason for hiding this comment

bwplotka Aug 6, 2021

Choose a reason for hiding this comment

michaljemala Aug 7, 2021

Choose a reason for hiding this comment

bwplotka Aug 6, 2021

Choose a reason for hiding this comment

michaljemala Aug 7, 2021

Choose a reason for hiding this comment

bwplotka Aug 6, 2021

Choose a reason for hiding this comment

michaljemala Aug 7, 2021

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

michaljemala commented Jul 13, 2021 •

edited

Loading

codecov-commenter commented Jul 14, 2021 •

edited

Loading