Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc-swagger-generator messes up the comments if there is rpc method that does not have rest #263

Closed
ggeorgiev opened this issue Nov 17, 2016 · 1 comment
Closed

protoc-swagger-generator messes up the comments if there is rpc method that does not have rest #263

ggeorgiev opened this issue Nov 17, 2016 · 1 comment

Comments

@ggeorgiev
Copy link

In case there is rpc method that does not support rest api (or does not have option (google.api.http)) the json generation gets confused and misaligns the comment for the methods.
@tmc
Copy link
Collaborator

tmc commented Nov 20, 2016 •
edited
Loading

this is because (*Registry).loadServices in github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway/descriptor/services.go skips over methods that don't define these mappings so the lookup by index gets off.

we should probably still create Methods with no Bindings for this case

tmc added a commit to tmc/grpc-gateway that referenced this issue Nov 20, 2016
@tmc
Allow methods with no bindings. Fixes grpc-ecosystem#263
b24cc22
@tmc tmc mentioned this issue Nov 20, 2016
Merged
yugui pushed a commit that referenced this issue Nov 28, 2016
@tmc @yugui
Allow methods with no bindings. Fixes #263 (#267)
199c40a
@tamalsaha tamalsaha mentioned this issue Mar 30, 2017
Closed
1 task
adasari pushed a commit to adasari/grpc-gateway that referenced this issue Apr 9, 2020
@tmc @yugui
Allow methods with no bindings. Fixes grpc-ecosystem#263 (grpc-ecosys…
4ec4364 
…tem#267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmc @ggeorgiev