Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: uncapitalized service name causes runtime error unknown function in service.pb.gw.go #484

Closed
thurt opened this issue Nov 12, 2017 · 1 comment · Fixed by #522
Closed

Comments

@thurt
Copy link
Contributor

thurt commented Nov 12, 2017

see title.

Steps to reproduce:

  1. define a service with a name that has a lowercase first letter in your service.proto
  2. generate the service.pb.go (notice that the generated code includes func NewNameClient -- it is capitalized Name)
  3. generate the service.pb.gw.go (notice that the generated code attempts to call NewnameClient -- uncapitalized name which leads to the runtime error)

this looks similar to #300 and looks like it could be fixed in the same way.

the style guide, https://developers.google.com/protocol-buffers/docs/style, says you should capitalize service names, but seems it does not say it requires capitalized. So i think this is a valid bug

@achew22
Copy link
Collaborator

achew22 commented Nov 16, 2017

I think you're totally correct. This would be a nice contribution for a first timer. I'll even point you to the appropriate code if you want 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants