Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ Adding related projects to the documentation #1946

Merged
merged 8 commits into from
Feb 11, 2021
Merged

FAQ Adding related projects to the documentation #1946

merged 8 commits into from
Feb 11, 2021

Conversation

rodoufu
Copy link
Contributor

@rodoufu rodoufu commented Feb 4, 2021

Closes: #1940

@google-cla
Copy link

google-cla bot commented Feb 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this, but please put it on a separate page.

docs/docs/faq.md Outdated
Comment on lines 28 to 37
If you do insist that your gateway should be written in the same language
as your server, there are a few projects that will help with this:

* NodeJS:
* [grps-dynamic-gateway](https://github.com/konsumer/grpc-dynamic-gateway)
* TypeScript / Javascript
* Not a direct analog, but [rest2grpc](https://www.npmjs.com/package/rest2grpc) is similar.
* Other languages
* Please add any references to other language implementations here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty hidden from users, I think it would be better with a new, separate page for "related projects". Could you add a new file under docs/docs/related_projects.md instead please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved it.

docs/docs/faq.md Outdated Show resolved Hide resolved
docs/docs/faq.md Outdated
Comment on lines 31 to 34
* NodeJS:
* [grps-dynamic-gateway](https://github.com/konsumer/grpc-dynamic-gateway)
* TypeScript / Javascript
* Not a direct analog, but [rest2grpc](https://www.npmjs.com/package/rest2grpc) is similar.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add the following too:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please let me know what do you think.

@johanbrandhorst
Copy link
Collaborator

Please rebase on master for flaky test fix

@google-cla
Copy link

google-cla bot commented Feb 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Feb 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Feb 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rodoufu
Copy link
Contributor Author

rodoufu commented Feb 5, 2021

Please rebase on master for flaky test fix

Done.
@johanbrandhorst please let me know if that is ok.

@rodoufu
Copy link
Contributor Author

rodoufu commented Feb 6, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 6, 2021
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove the changes to the FAQ please.

docs/docs/faq.md Outdated Show resolved Hide resolved
docs/docs/related_projects.md Outdated Show resolved Hide resolved
@johanbrandhorst johanbrandhorst merged commit f700373 into grpc-ecosystem:master Feb 11, 2021
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@rodoufu rodoufu deleted the patch-1 branch September 27, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non official implementation
2 participants