-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAQ Adding related projects to the documentation #1946
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for this, but please put it on a separate page.
docs/docs/faq.md
Outdated
If you do insist that your gateway should be written in the same language | ||
as your server, there are a few projects that will help with this: | ||
|
||
* NodeJS: | ||
* [grps-dynamic-gateway](https://github.com/konsumer/grpc-dynamic-gateway) | ||
* TypeScript / Javascript | ||
* Not a direct analog, but [rest2grpc](https://www.npmjs.com/package/rest2grpc) is similar. | ||
* Other languages | ||
* Please add any references to other language implementations here. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is pretty hidden from users, I think it would be better with a new, separate page for "related projects". Could you add a new file under docs/docs/related_projects.md
instead please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved it.
docs/docs/faq.md
Outdated
* NodeJS: | ||
* [grps-dynamic-gateway](https://github.com/konsumer/grpc-dynamic-gateway) | ||
* TypeScript / Javascript | ||
* Not a direct analog, but [rest2grpc](https://www.npmjs.com/package/rest2grpc) is similar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add the following too:
- Google Cloud Platform HTTP/JSON gRPC transcoding: https://cloud.google.com/endpoints/docs/grpc/transcoding
- Envoy proxy gRPC-JSON transcoder: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/grpc_json_transcoder_filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, please let me know what do you think.
Please rebase on master for flaky test fix |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Done. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove the changes to the FAQ please.
Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Thanks for your contribution! |
Closes: #1940