readme: added links to additional documentation #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds links to the google cloud platform's documentation on the custom options used by grpc-gateway to generate your http proxy. This documentation has information about how path, query, and body parameters are handled, as well as specific assumptions about the arguments present for different http methods. Fixes grpc-ecosystem#212
|
@sdemos Thank you for your help. The automatic process is failing to check if you have signed Google CLA for a technical reason. Have you signed? |
|
I hadn't done that. It should be all set to go now. |
|
@sdemos Thanks. LGTM. |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
readme: added links to additional documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds links to the google cloud platform's documentation on the custom options used by grpc-gateway to generate your http proxy. This documentation has information about how path, query, and body parameters are handled, as well as specific assumptions about the arguments present for different http methods.
I added the link in a couple of places in the readme that seemed like places where you might want additional documentation. Let me know if they should be linked to differently or something like that.
Fixes #212