Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass permanent HTTP request headers #252

Merged
merged 3 commits into from
Jan 11, 2017
Merged

Conversation

tmc
Copy link
Collaborator

@tmc tmc commented Nov 5, 2016

This is a rework/revival of #213 with the following changes:

  • 'grpcgateway-' metadata prefix is specified and documented.
  • the 'authorization' header is passed as it was before, preserving backwards compatibility.
  • MetadataHeaderPrefix comment is changed to be more accurate.

Further work would include the ability to explicitly whitelist additional parameters but we should do that in a separate diff.

@tmc tmc changed the title Pass Permanent HTTP request headers. Pass Permanent HTTP request headers Nov 5, 2016
@tmc tmc changed the title Pass Permanent HTTP request headers Pass permanent HTTP request headers Nov 5, 2016
@tmc
Copy link
Collaborator Author

tmc commented Nov 15, 2016

@willnorris any info on the cla/google check hanging?

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@tmc
Copy link
Collaborator Author

tmc commented Nov 15, 2016

Ah. @christianvozar can you fill out the google cla at https://cla.developers.google.com ?

@willnorris
Copy link

@tmc, as noted in the comment from @googlebot, @christianvozar has already signed the CLA (emphasis added):

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors

Them problem is that you are submitting a pull request including code authored by someone else, so we just want that someone else to confirm that they're okay with their code being contributed to the project. The CLA status won't actually change from it's current state, but it's okay to merge once @christianvozar has indicated agreement.

@tmc
Copy link
Collaborator Author

tmc commented Nov 20, 2016

@willnorris this project uses GitHub's protected branches feature to prevent direct pushes to master -- how likely is it that the googlebot will learn how to deal with this situation?

@yugui if the answer is not likely then we I/we need another path to get these types of PRs in.

@yugui
Copy link
Member

yugui commented Nov 28, 2016

@christianvozar Can I merge your contribution in this PR into this repository?

@yugui yugui merged commit a51e1d5 into grpc-ecosystem:master Jan 11, 2017
@tmc tmc deleted the 213-revival branch March 30, 2017 18:40
@tamalsaha tamalsaha mentioned this pull request Mar 30, 2017
1 task
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
* Pass Permanent Request Headers

* Fix tests and update pr213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants