Correct runtime.errorBody protobuf field tag #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmc
changed the title
tmc
force-pushed
the
fix_error_code_tag
branch
from
9e087f1
to
4b8acda
Compare
tmc
force-pushed
the
fix_error_code_tag
branch
from
4b8acda
to
3ec1df8
Compare
|
@yugui, @kazegusuri / others, can I get a review here? |
|
LGTM |
|
LGTM. @yugui can you please take a look? |
This was referenced Nov 22, 2016
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
Correct runtime.errorBody protobuf field tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag field on errorBody.Code should be
varintnotbytesas well asint32vsint-- the protobuf library printsproto: no coders for intto stderr when marshaling these errors.