-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 669 #693
Fix issue 669 #693
Conversation
Thanks a lot for the investigation and the fix! If you could add a changelog entry describing your change (with a link to this PR), as well as adding the information from #669 (comment) to this PR description, that would help a lot. |
Done and fixed the two issues with the workflow. |
I´m getting this error in the other workflow:
Since 3.2.4 has already released, I will change both to 3.2.5. |
publish / validate validate packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! If you could add a small test for this to not risk having regressions, we can merge.
Test added. |
The error when running dart / test (windows-latest) when running |
Right, I will take a look. |
Is there anything else needed here? |
PR HealthBreaking changes ✔️Details
Changelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️Details
This check for test coverage is informational (issues shown here will not fail the PR). API leaks
|
Package | Leaked API symbols |
---|---|
grpc | $1.Duration ServerHandler Any |
This check can be disabled by tagging the PR with skip-leaking-check
.
Package publish validation ✔️
Details
Package | Version | Status |
---|---|---|
package:grpc | 3.2.5 | ready to publish |
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
The failed tests complaining about |
https://grpc.github.io/grpc/core/md_doc_compression.html indicates that compression flag should not be set if grpc-encoding is identity.
This PR makes grpc-dart set the compression flag properly in this case.