Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rev package:lints #740

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Rev package:lints #740

merged 6 commits into from
Oct 1, 2024

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented Sep 30, 2024

Ignore the unintended_html_in_doc_comment lint, as the lint fires on generated code from imported protobufs.

Supersedes #739.

Copy link

github-actions bot commented Sep 30, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
grpc None 4.0.2-wip 4.0.2-wip 4.0.2-wip ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
lib/service_api.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
grpc Any
$1.Duration
ServerHandler

This check can be disabled by tagging the PR with skip-leaking-check.

Package publish validation ✔️
Package Version Status
package:grpc 4.0.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 30, 2024
@grpc grpc deleted a comment from github-actions bot Sep 30, 2024
.github/workflows/dart.yml Outdated Show resolved Hide resolved
.github/workflows/dart.yml Outdated Show resolved Hide resolved
mosuem and others added 2 commits October 1, 2024 10:27
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
@mosuem mosuem merged commit 04ba68e into master Oct 1, 2024
21 checks passed
@mosuem mosuem deleted the revLinter branch October 1, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants