Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadline timer rescheduling because of timer precision #1201

Merged
merged 5 commits into from
Feb 12, 2021
Merged

Fix deadline timer rescheduling because of timer precision #1201

merged 5 commits into from
Feb 12, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 12, 2021 •
edited
Loading

Also, don't log OperationCanceledException in client when deadline has been exceeded.

Avoid this situation:

 0.203s Grpc.Net.Client.Internal.GrpcCall - Trace: Deadline timer triggered but 00:00:00.0009580 remaining before deadline exceeded. Deadline timer rescheduled.
 0.203s Grpc.Net.Client.Internal.GrpcCall - Trace: Deadline timer triggered but 00:00:00.0008698 remaining before deadline exceeded. Deadline timer rescheduled.

@JamesNK JamesNK requested a review from JunTaoLuo February 12, 2021 22:49
@JamesNK JamesNK mentioned this pull request Feb 12, 2021
Merged
6 tasks
@JamesNK JamesNK merged commit 538e372 into grpc:master Feb 12, 2021
@JamesNK JamesNK deleted the jamesnk/deadline-reschedule branch February 12, 2021 23:19
This was referenced Mar 18, 2021
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesNK @JunTaoLuo