Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move static Log classes out of generic types #1253

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Move static Log classes out of generic types #1253

merged 2 commits into from
Apr 1, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Mar 31, 2021

Fields on static Log classes inside a generic type are duplicated with each type parameter.

Move static logging outside of generic types.

@JamesNK JamesNK requested a review from JunTaoLuo March 31, 2021 08:48
JunTaoLuo
JunTaoLuo approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool. How much does this save?

@JamesNK
Copy link
Member Author

JamesNK commented Apr 1, 2021

I haven't measured. Depends on how many services and message types you have in an app.

@JamesNK JamesNK merged commit 7e3f2c3 into grpc:master Apr 1, 2021
@JamesNK JamesNK deleted the jamesnk/log-refactor branch April 1, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesNK @JunTaoLuo