Add downloader example #1689
Closed
Add downloader example #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JamesNK
reviewed
Apr 18, 2022
| if (message.Metadata != null) | ||
| { | ||
| Console.WriteLine("Saving metadata to file"); | ||
| string metadata = message.Metadata.ToString(); |
There was a problem hiding this comment.
Suggested change
| string metadata = message.Metadata.ToString(); | |
| var metadata = message.Metadata.ToString(); |
Comment on lines
+47
to
+49
| while (await call.ResponseStream.MoveNext()) | ||
| { | ||
| var message = call.ResponseStream.Current; |
There was a problem hiding this comment.
Suggested change
| while (await call.ResponseStream.MoveNext()) | |
| { | |
| var message = call.ResponseStream.Current; | |
| await foreach (var message in call.ResponseStream.ReadAllAsync()) | |
| { |
Comment on lines
+64
to
+65
| Console.WriteLine("\nFiles were saved in: " + downloadIdPath); | ||
| Console.WriteLine("\nPress any key to exit..."); |
There was a problem hiding this comment.
What's the purpose of \n here? IMO use Console.WriteLine() to add additional line breaks if desired.
Comment on lines
+18
to
+19
|
|
||
|
|
Comment on lines
+23
to
+24
|
|
||
|
|
| } | ||
| }); | ||
|
|
||
| var buffer = new byte[ChunkSize]; |
There was a problem hiding this comment.
Suggested change
| var buffer = new byte[ChunkSize]; | |
| var buffer = new byte[ChunkSize]; |
Comment on lines
+44
to
+49
| await responseStream.WriteAsync(new DownloadFileResponse { | ||
| Metadata = new FileMetadata | ||
| { | ||
| FileName = filename | ||
| } | ||
| }); |
There was a problem hiding this comment.
Suggested change
| await responseStream.WriteAsync(new DownloadFileResponse { | |
| Metadata = new FileMetadata | |
| { | |
| FileName = filename | |
| } | |
| }); | |
| await responseStream.WriteAsync(new DownloadFileResponse | |
| { | |
| Metadata = new FileMetadata { FileName = filename } | |
| }); |
| _logger.LogInformation("Sending data chunk of {numBytesRead} bytes", numBytesRead); | ||
| await responseStream.WriteAsync(new DownloadFileResponse | ||
| { | ||
| Data = UnsafeByteOperations.UnsafeWrap(buffer.AsMemory(0, numBytesRead)) |
There was a problem hiding this comment.
Suggested change
| Data = UnsafeByteOperations.UnsafeWrap(buffer.AsMemory(0, numBytesRead)) | |
| Data = UnsafeByteOperations.UnsafeWrap(buffer.AsMemory(0, numBytesRead)) |
|
|
||
| while (true) | ||
| { | ||
| int numBytesRead = await fileStream.ReadAsync(buffer); |
There was a problem hiding this comment.
Suggested change
| int numBytesRead = await fileStream.ReadAsync(buffer); | |
| var numBytesRead = await fileStream.ReadAsync(buffer); |
Comment on lines
+292
to
+293
|
|
||
|
|
|
i'm not sure how to edit this pull request without tons of commits. |
|
Lots of commits are fine. Squash merging is simple. |
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
finished this example,
let me know if there's something to improve here :)
( Closes #1680 )