-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly check socket on stream creation #2215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wolffy101
reviewed
Jul 31, 2023
src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
Outdated
Show resolved
Hide resolved
JamesNK
commented
Jul 31, 2023
src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
Outdated
Show resolved
Hide resolved
amcasey
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible to me. I don't consider any of my suggestions blocking.
src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
Outdated
Show resolved
Hide resolved
src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
Outdated
Show resolved
Hide resolved
src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
Outdated
Show resolved
Hide resolved
src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
Outdated
Show resolved
Hide resolved
src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
Outdated
Show resolved
Hide resolved
src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
Outdated
Show resolved
Hide resolved
src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
Outdated
Show resolved
Hide resolved
src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2210
I recreated the error from #2210. The previous fix (socket timeout) will address this issue for the vast majority of people. However, some servers may have configured a timeout of less than 60 seconds. They could still run into problems.
Previously if a server had written data to the socket (e.g. HTTP/2 GOAWAY frame) and closed it, then it would incorrectly be seen as healthy. This PR updates the stream creation method to correctly check that a socket is still healthy before using it. This involves reusing the check logic from the ping that reads available data. When available data is read, the client will see the socket is closed and create a new one for the connection.