Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly check socket on stream creation #2215

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 29, 2023

Fixes #2210

I recreated the error from #2210. The previous fix (socket timeout) will address this issue for the vast majority of people. However, some servers may have configured a timeout of less than 60 seconds. They could still run into problems.

Previously if a server had written data to the socket (e.g. HTTP/2 GOAWAY frame) and closed it, then it would incorrectly be seen as healthy. This PR updates the stream creation method to correctly check that a socket is still healthy before using it. This involves reusing the check logic from the ping that reads available data. When available data is read, the client will see the socket is closed and create a new one for the connection.

Copy link
Contributor

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me. I don't consider any of my suggestions blocking.

@JamesNK JamesNK merged commit a2d005c into grpc:master Aug 2, 2023
@JamesNK JamesNK deleted the jamesnk/connectivity-improvement branch August 2, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants