Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to create GrpcChannel under Wine compatibility layer (including Steam Proton and Apple Game Porting Toolkit) #2496

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

mayuki
Copy link
Contributor

@mayuki mayuki commented Jul 30, 2024

Wine compatibility layers such as Steam Deck/Steam OS Proton and the Apple Game Porting Toolkit return Windows 8 or later as the OS version, but does not implement the GetCurrentApplicationUserModelId API.

As a result, an issue occurs where it is not possible to create a GrpcChannel due to an EntryPointNotFoundException.

System.TypeInitializationException: The type initializer for 'Grpc.Net.Client.Internal.OperatingSystem' threw an exception. ---> System.EntryPointNotFoundException: GetCurrentApplicationUserModelId assembly:<unknown assembly> type:<unknowntype> member:(null)
  at (wrapper managed-to-native) Grpc.Net.Client.Internal.Native.GetCurrentApplicationUserModelId(uint&,byte[])
  at Grpc.Net.Client.Internal.Native.IsUwp (System.String frameworkDescription, System.Version version) [0x00028] in <cfd57654def7423a841054daeb7fc483>:0
  at Grpc.Net.Client.Internal.OperatingSystem..ctor () [0x00049] in <cfd57654def7423a841054daeb7fc483>:0
  at Grpc.Net.Client.Internal.OperatingSystem..cctor () [0x00000] in <cfd57654def7423a841054daeb7fc483>:0

For example, if using Grpc.Net.Client in a game developed with Unity, the game will not be playable on Steam Deck.

@JamesNK
Copy link
Member

JamesNK commented Jul 30, 2024

Do you have a link to a web page that discusses this? It would be good to include that in the comment so people can look their if they want more information.

@mayuki
Copy link
Contributor Author

mayuki commented Jul 30, 2024

This originated from a report from one of our clients, and I'm sorry to say there is no similar discussion on the web.

@JamesNK JamesNK merged commit 540e87b into grpc:master Jul 30, 2024
3 checks passed
@JamesNK
Copy link
Member

JamesNK commented Jul 30, 2024

Thanks for the good description and fix.

@mayuki mayuki deleted the FixIssueUnderWineCompatLayer branch July 30, 2024 03:28
oguzhand95 referenced this pull request in cerbos/cerbos-sdk-net Sep 23, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[Google.Protobuf](https://github.com/protocolbuffers/protobuf)
| `3.28.1` -> `3.28.2` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Google.Protobuf/3.28.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Google.Protobuf/3.28.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Google.Protobuf/3.28.1/3.28.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Google.Protobuf/3.28.1/3.28.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [Grpc.Net.Client](https://github.com/grpc/grpc-dotnet) |
`2.65.0` -> `2.66.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Grpc.Net.Client/2.66.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Grpc.Net.Client/2.66.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Grpc.Net.Client/2.65.0/2.66.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Grpc.Net.Client/2.65.0/2.66.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary>

###
[`v2.66.0`](https://github.com/grpc/grpc-dotnet/releases/tag/v2.66.0)

#### What's Changed

- Bump version on master to 2.66.0-dev by
[@&#8203;stanley-cheung](https://github.com/stanley-cheung) in
[https://github.com/grpc/grpc-dotnet/pull/2491](https://github.com/grpc/grpc-dotnet/pull/2491)
- Fix failure to create GrpcChannel under Wine compatibility layer
(including Steam Proton and Apple Game Porting Toolkit) by
[@&#8203;mayuki](https://github.com/mayuki) in
[https://github.com/grpc/grpc-dotnet/pull/2496](https://github.com/grpc/grpc-dotnet/pull/2496)
- Update .NET 9 SDK and resolve warnings by
[@&#8203;sebastienros](https://github.com/sebastienros) in
[https://github.com/grpc/grpc-dotnet/pull/2502](https://github.com/grpc/grpc-dotnet/pull/2502)
- Bump braces from 3.0.2 to 3.0.3 in
/testassets/InteropTestsGrpcWebWebsite/Tests by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/grpc/grpc-dotnet/pull/2504](https://github.com/grpc/grpc-dotnet/pull/2504)
- Bump axios from 1.6.2 to 1.7.4 in
/testassets/InteropTestsGrpcWebWebsite/Tests by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/grpc/grpc-dotnet/pull/2505](https://github.com/grpc/grpc-dotnet/pull/2505)
- Update puppeteer by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2507](https://github.com/grpc/grpc-dotnet/pull/2507)
- Remove internal_ci flag from interop test script by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2509](https://github.com/grpc/grpc-dotnet/pull/2509)
- Fix Google auth interop test by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2512](https://github.com/grpc/grpc-dotnet/pull/2512)
- \[testing] improve sanity check in jwt_token_creds interop test by
[@&#8203;apolcyn](https://github.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2513](https://github.com/grpc/grpc-dotnet/pull/2513)
- Add HTTP version configuration to GrpcChannelOptions by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2514](https://github.com/grpc/grpc-dotnet/pull/2514)
- Bump grpc.tools version to 2.66 by
[@&#8203;apolcyn](https://github.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2523](https://github.com/grpc/grpc-dotnet/pull/2523)
- Bump webpack from 5.76.0 to 5.94.0 in /examples/Browser/Server/wwwroot
by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/grpc/grpc-dotnet/pull/2522](https://github.com/grpc/grpc-dotnet/pull/2522)
- Bump elliptic from 6.5.4 to 6.5.7 in /examples/Spar/Server/ClientApp
by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/grpc/grpc-dotnet/pull/2525](https://github.com/grpc/grpc-dotnet/pull/2525)
- Bump micromatch from 4.0.7 to 4.0.8 in
/testassets/InteropTestsGrpcWebWebsite/Tests by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/grpc/grpc-dotnet/pull/2524](https://github.com/grpc/grpc-dotnet/pull/2524)
- Bump v2.66.x branch to 2.66.0.pre1 by
[@&#8203;apolcyn](https://github.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2526](https://github.com/grpc/grpc-dotnet/pull/2526)
- Bump v2.66.x to v2.66.0 by
[@&#8203;apolcyn](https://github.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2539](https://github.com/grpc/grpc-dotnet/pull/2539)

**Full Changelog**:
grpc/grpc-dotnet@v2.65.0...v2.66.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config
help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/cerbos/cerbos-sdk-net).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXJlYS9jaSIsImJvdHMiLCJraW5kL2Nob3JlIl19-->

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants