Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for bug in System.CommandLine #512

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Workaround for bug in System.CommandLine #512

merged 2 commits into from
Sep 16, 2019

Conversation

shirhatti
Copy link
Contributor

There are a bunch of bugs in System.CommandLine when using the TestConsole

  • System.Console.WindowWidth (and WindowHeight) throws an IOException
  • SystemConsoleTerminal.HideCursor() (and ShowCursor()) throws an IOException

Additionally, there was a small logic bug

screen.Render(new Region(0, 0, System.Console.WindowWidth, System.Console.WindowWidth));
                                                                          ^^^^ Should have been WindowHeight

This addresses #457

@thelinuxfoundation
Copy link
Collaborator

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@linux-foundation-easycla
Copy link

CLA Check
One or more committers are not authorized under a signed CLA as indicated below. Please click here to be authorized.

@shirhatti shirhatti closed this Sep 13, 2019
@shirhatti shirhatti reopened this Sep 13, 2019
src/dotnet-grpc/Commands/ListCommand.cs Show resolved Hide resolved
test/dotnet-grpc.Tests/ListCommandTests.cs Outdated Show resolved Hide resolved
test/dotnet-grpc.Tests/ListCommandTests.cs Outdated Show resolved Hide resolved
@JamesNK JamesNK requested a review from JunTaoLuo September 15, 2019 20:25
@JamesNK JamesNK merged commit aad959b into grpc:master Sep 16, 2019
@shirhatti shirhatti deleted the shirhatti/fix_List_ListsReferences branch September 16, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants