Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make service and interceptor activators public #677

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Dec 3, 2019

Fixes #671

@davidfowl
Copy link
Contributor

@JamesNK might be worthwhile adding a test with a dummy implementation (like a fake container).

Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you be taking any action on the other asks of the issue? Making these types public was listed as the first step, but there's also asks for making it non-generic. We should clarify either way.

Edit: NVM I see the rework happening in https://github.com/grpc/grpc-dotnet/pull/669/files.

@jtattermusch
Copy link
Contributor

I'm ok with this, but if we do that, we are committing to API stability for the interfaces, so I'd like us to think twice. @JamesNK @JunTaoLuo

@JamesNK
Copy link
Member Author

JamesNK commented Dec 10, 2019

The API shape has been debated a lot and I think this is the best solution.

I'll get the original requester of this feature to double check it works for them before the package is finalized.

@JamesNK JamesNK merged commit 40da668 into grpc:master Dec 10, 2019
@JamesNK JamesNK deleted the jamesnk/activators branch December 10, 2019 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for non-conforming containers by adding a public IGrpcServiceActivator abstraction
4 participants