Fix error when client has a very large deadline #762
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #751
@shshzi I ended up using the solution you suggested. There is a limit of 99999999 seconds that matches what I found in Grpc.Core.
Also makes the calls with a past deadline fail immediately, without sending a HTTP request to the server. @jtattermusch I saw that behavior in ccore but it would be great if you could confirm that is how gRPC clients handle starting a call with a deadline that has already past.