Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client should avoid sending too many streams that exceeds server max stream limits #1060

Closed
adelez opened this issue Feb 1, 2017 · 2 comments · Fixed by #1071
Closed

Client should avoid sending too many streams that exceeds server max stream limits #1060

adelez opened this issue Feb 1, 2017 · 2 comments · Fixed by #1071
Assignees
@MakMukhi

Comments

@adelez
Copy link
Contributor

adelez commented Feb 1, 2017

Stress test shows that the client can send many streams at once to server that it exceeds server max stream limit 100. In this case, client will receive rst_stream with internal error.

Per discussion with @ejona86, Java and C use an tentative value of 100 for MAX_CONCURRENT_STREAMS before receiving the initial SETTINGS. This would avoid this situation.
@mwitkow
Copy link
Contributor

mwitkow commented Feb 6, 2017

@menghanl Could we please get a parameter for this? We've been hitting rst_stream on our requsts to Datastore over gRPC and would like to validate if that's the case.

@ejona86
Copy link
Member

ejona86 commented Feb 6, 2017

There should be no need for a parameter for this. The default behavior should just be fixed.

@menghanl menghanl assigned MakMukhi and unassigned menghanl Feb 10, 2017
MakMukhi added a commit to MakMukhi/grpc-go that referenced this issue Feb 10, 2017
@MakMukhi
Issue grpc#1060 maximum number of streams on the client should be cap…
9e922bd 
…ped at 100 by default
@MakMukhi MakMukhi mentioned this issue Feb 10, 2017
Merged
menghanl added a commit that referenced this issue Mar 1, 2017
@menghanl
Merge pull request #1071 from MakMukhi/issue_1060
8b2e129 
Issue #1060 maximum number of streams on the client should be capped …
@hsaliak hsaliak reopened this Apr 2, 2018
@hsaliak hsaliak closed this as completed Apr 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MakMukhi MakMukhi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #1060 maximum number of streams on the client should be capped … MakMukhi/grpc-go
6 participants
@hsaliak @menghanl @ejona86 @mwitkow @adelez @MakMukhi