Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godep save fails on empty grpc_lb_v1 package for grpc 1.6+ #1733

Closed
jpbetz opened this issue Dec 13, 2017 · 4 comments
Closed

godep save fails on empty grpc_lb_v1 package for grpc 1.6+ #1733

jpbetz opened this issue Dec 13, 2017 · 4 comments
Assignees

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Dec 13, 2017

When upgrading kubernetes from grpc 1.3.0 to 1.7.4, godep save reported this error:

godep: no buildable Go source files in /usr/local/google/home/jpbetz/Projects/k8s/src/k8s.io/kubernetes/_output/local/go/src/google.golang.org/grpc/grpclb/grpc_lb_v1                                                                                                                              
 !!! Error in hack/godep-save.sh:69
...

After locally adding a doc.go placeholder file to the grpc/grpclb/grpc_lb_v1 dir in grpc source, the godep save command ran successfully.

I'll attempt to create a minimal example that reproduces the issue.

go version go1.9.1 linux/amd64
godep v79 (linux/amd64/go1.8.1.typealias)
kubernetes master (@ b97e17603b)
@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 14, 2017

Was able to resolve this. Once the grpc/grpclb/grpc_lb_v1 package was excluded (godep get google.golang.org/grpc/... will exclude it) as will removing it from Godeps.json, godeps correctly ignored the directory.

@jpbetz jpbetz closed this as completed Dec 14, 2017
@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 14, 2017

godep issue: tools/godep#554

@dfawley
Copy link
Member

dfawley commented Dec 14, 2017

Thanks! I had a feeling that was the problem -- we have no .go files in that path, so the error is accurate; it's just not clear why it would be an error.

@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 15, 2017

@dfawley If you're willing to merge it, #1743 would be a huge help to kubernetes for getting grpc upgraded. We're currently stuck on 1.3.0. We'd need a new 1.7.x cut with it though..

I was hoping that maybe we could get this fixed in godep, but the project has had no activity since February this year, so I'm doubtful that even if we authored the PR that it would get merged. The only other paths forward are #1743 or to wait till a large number of kubernetes' transitive dependencies are on grpc 1.7.x.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants