Add doc.go to grpc_lb_v1 #1743
Closed
Add doc.go to grpc_lb_v1 #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2017
|
I don't really like the idea of a package that exists only to work around a bug in godep. How about if we check this in on the 1.7.x branch, which is the one you need, and hope they fix the issue before you move to a later gRPC release? |
|
@dfawley Totally understand. We're just grasping for workarounds until we can migrate of godep entirely. Patching 1.7.x only would work for us. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In grpc 1.6.0 and earlier
grpc/grpclb/grpc_lb_v1was a package. But now that it contains no go files, it is no longer considered a package. While this should be fine (since it didn't contribute to the developer facing API as far as I can tel), it has caused problems for tools like godep (tools/godep#554).It would be a huge help to kubernetes if we could mitigate this problem, and it can potentially be done cleanly with this PR, which adds some documentation to the
grpc_lb_v1package, and by introducing a go file in the directory, makes go consider it a package once again.