grpc_lb_v1: add doc.go to work around godep bug #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dfawley
approved these changes
Dec 15, 2017
|
Test failure: |
jpbetz
force-pushed
the
grpc_lb_v1_doc
branch
from
cb0f7ee
to
7007987
Compare
|
Added pkg to list of ignored golint files. |
dfawley
changed the title
|
FYI, just did |
|
Thanks @menghanl ! Applying 1.7.5 to kubernetes now. Tests are passing locally and I expect kubernetes/kubernetes#57160 to merge once e2e tests pass. |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Dec 19, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Version bump to etcd v3.2.11, grpc v1.7.5 Fix #56114: Update to etcd client 3.2.11 Version bumps: - etcd from 3.1.10 to 3.2.11 - grpc from 1.3.0 to 1.7.5 - grpc-gateway from v1.1.0-25-g84398b9 to v1.3.0 TODO: - [x] Apply etcd [3.2 client upgrade guide](https://github.com/coreos/etcd/blob/master/Documentation/upgrades/upgrade_3_2.md) - [x] Apply grpc API changes in 1.6.0 and 1.7.0 [release notes](https://github.com/grpc/grpc-go/releases) - [x] bbolt was pulled in transitively, why? We have tests that embed etcd, so we must vendor the etcd server and all it's dependencies. - [x] Upgrade to containerd v1.0.0? Currently kubernetes depends on containerd v1.0.0-beta.2-159-g27d450a0 which depends on grpc v1.3.0, but containerd v1.0.0 depends on grpc 1.7.2. Not needed. The containerd grpc upgrade required [no code changes](containerd/containerd@ce3e326). - [x] Fix all failing tests - [x] Ensure we can safely upgrade grpc to 1.7.5 given that docker and cAdvisor still depend on grpc 1.3.0 (both in the versions we vend and on master for both projects). Should we hold off on this change until we have a docker release that uses gprc 1.7.x? - [x] Wait for grpc 1.7.5 to be released (it will include grpc/grpc-go#1747). Once released, bump grpc version in this PR and remove workarounds in `hack/godep-save.sh`. Transitive dependencies on grpc: - docker depends on grpc, but according to the package dependency graph (`go list -f '{{ .Deps }}'`) there are no dependencies from kubernetes to grpc via docker packages. - containerd v1.0.0 depends on grpc 1.7.2, we should upgrade to containerd v1.0.0 soon, this can be done in a separate PR - cadvisor depends on grpc 1.3.0 on master, it should upgrade it to grpc 1.7.5, this can be done in a separate PR **Release note**: ```release-note Upgrade to etcd client 3.2.11 and grpc 1.7.5 to improve HA etcd cluster stability. ```
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this pull request
Dec 19, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Version bump to etcd v3.2.11, grpc v1.7.5 Fix kubernetes/kubernetes#56114: Update to etcd client 3.2.11 Version bumps: - etcd from 3.1.10 to 3.2.11 - grpc from 1.3.0 to 1.7.5 - grpc-gateway from v1.1.0-25-g84398b9 to v1.3.0 TODO: - [x] Apply etcd [3.2 client upgrade guide](https://github.com/coreos/etcd/blob/master/Documentation/upgrades/upgrade_3_2.md) - [x] Apply grpc API changes in 1.6.0 and 1.7.0 [release notes](https://github.com/grpc/grpc-go/releases) - [x] bbolt was pulled in transitively, why? We have tests that embed etcd, so we must vendor the etcd server and all it's dependencies. - [x] Upgrade to containerd v1.0.0? Currently kubernetes depends on containerd v1.0.0-beta.2-159-g27d450a0 which depends on grpc v1.3.0, but containerd v1.0.0 depends on grpc 1.7.2. Not needed. The containerd grpc upgrade required [no code changes](containerd/containerd@ce3e326). - [x] Fix all failing tests - [x] Ensure we can safely upgrade grpc to 1.7.5 given that docker and cAdvisor still depend on grpc 1.3.0 (both in the versions we vend and on master for both projects). Should we hold off on this change until we have a docker release that uses gprc 1.7.x? - [x] Wait for grpc 1.7.5 to be released (it will include grpc/grpc-go#1747). Once released, bump grpc version in this PR and remove workarounds in `hack/godep-save.sh`. Transitive dependencies on grpc: - docker depends on grpc, but according to the package dependency graph (`go list -f '{{ .Deps }}'`) there are no dependencies from kubernetes to grpc via docker packages. - containerd v1.0.0 depends on grpc 1.7.2, we should upgrade to containerd v1.0.0 soon, this can be done in a separate PR - cadvisor depends on grpc 1.3.0 on master, it should upgrade it to grpc 1.7.5, this can be done in a separate PR **Release note**: ```release-note Upgrade to etcd client 3.2.11 and grpc 1.7.5 to improve HA etcd cluster stability. ``` Kubernetes-commit: a7b404ec7f7cbf153573b7b7e4b84267f36135d0
k8s-publishing-bot
added a commit
to kubernetes/kube-aggregator
that referenced
this pull request
Dec 19, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Version bump to etcd v3.2.11, grpc v1.7.5 Fix kubernetes/kubernetes#56114: Update to etcd client 3.2.11 Version bumps: - etcd from 3.1.10 to 3.2.11 - grpc from 1.3.0 to 1.7.5 - grpc-gateway from v1.1.0-25-g84398b9 to v1.3.0 TODO: - [x] Apply etcd [3.2 client upgrade guide](https://github.com/coreos/etcd/blob/master/Documentation/upgrades/upgrade_3_2.md) - [x] Apply grpc API changes in 1.6.0 and 1.7.0 [release notes](https://github.com/grpc/grpc-go/releases) - [x] bbolt was pulled in transitively, why? We have tests that embed etcd, so we must vendor the etcd server and all it's dependencies. - [x] Upgrade to containerd v1.0.0? Currently kubernetes depends on containerd v1.0.0-beta.2-159-g27d450a0 which depends on grpc v1.3.0, but containerd v1.0.0 depends on grpc 1.7.2. Not needed. The containerd grpc upgrade required [no code changes](containerd/containerd@ce3e326). - [x] Fix all failing tests - [x] Ensure we can safely upgrade grpc to 1.7.5 given that docker and cAdvisor still depend on grpc 1.3.0 (both in the versions we vend and on master for both projects). Should we hold off on this change until we have a docker release that uses gprc 1.7.x? - [x] Wait for grpc 1.7.5 to be released (it will include grpc/grpc-go#1747). Once released, bump grpc version in this PR and remove workarounds in `hack/godep-save.sh`. Transitive dependencies on grpc: - docker depends on grpc, but according to the package dependency graph (`go list -f '{{ .Deps }}'`) there are no dependencies from kubernetes to grpc via docker packages. - containerd v1.0.0 depends on grpc 1.7.2, we should upgrade to containerd v1.0.0 soon, this can be done in a separate PR - cadvisor depends on grpc 1.3.0 on master, it should upgrade it to grpc 1.7.5, this can be done in a separate PR **Release note**: ```release-note Upgrade to etcd client 3.2.11 and grpc 1.7.5 to improve HA etcd cluster stability. ``` Kubernetes-commit: a7b404ec7f7cbf153573b7b7e4b84267f36135d0
k8s-publishing-bot
added a commit
to kubernetes/sample-apiserver
that referenced
this pull request
Dec 19, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Version bump to etcd v3.2.11, grpc v1.7.5 Fix kubernetes/kubernetes#56114: Update to etcd client 3.2.11 Version bumps: - etcd from 3.1.10 to 3.2.11 - grpc from 1.3.0 to 1.7.5 - grpc-gateway from v1.1.0-25-g84398b9 to v1.3.0 TODO: - [x] Apply etcd [3.2 client upgrade guide](https://github.com/coreos/etcd/blob/master/Documentation/upgrades/upgrade_3_2.md) - [x] Apply grpc API changes in 1.6.0 and 1.7.0 [release notes](https://github.com/grpc/grpc-go/releases) - [x] bbolt was pulled in transitively, why? We have tests that embed etcd, so we must vendor the etcd server and all it's dependencies. - [x] Upgrade to containerd v1.0.0? Currently kubernetes depends on containerd v1.0.0-beta.2-159-g27d450a0 which depends on grpc v1.3.0, but containerd v1.0.0 depends on grpc 1.7.2. Not needed. The containerd grpc upgrade required [no code changes](containerd/containerd@ce3e326). - [x] Fix all failing tests - [x] Ensure we can safely upgrade grpc to 1.7.5 given that docker and cAdvisor still depend on grpc 1.3.0 (both in the versions we vend and on master for both projects). Should we hold off on this change until we have a docker release that uses gprc 1.7.x? - [x] Wait for grpc 1.7.5 to be released (it will include grpc/grpc-go#1747). Once released, bump grpc version in this PR and remove workarounds in `hack/godep-save.sh`. Transitive dependencies on grpc: - docker depends on grpc, but according to the package dependency graph (`go list -f '{{ .Deps }}'`) there are no dependencies from kubernetes to grpc via docker packages. - containerd v1.0.0 depends on grpc 1.7.2, we should upgrade to containerd v1.0.0 soon, this can be done in a separate PR - cadvisor depends on grpc 1.3.0 on master, it should upgrade it to grpc 1.7.5, this can be done in a separate PR **Release note**: ```release-note Upgrade to etcd client 3.2.11 and grpc 1.7.5 to improve HA etcd cluster stability. ``` Kubernetes-commit: a7b404ec7f7cbf153573b7b7e4b84267f36135d0
k8s-publishing-bot
added a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
Dec 19, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Version bump to etcd v3.2.11, grpc v1.7.5 Fix kubernetes/kubernetes#56114: Update to etcd client 3.2.11 Version bumps: - etcd from 3.1.10 to 3.2.11 - grpc from 1.3.0 to 1.7.5 - grpc-gateway from v1.1.0-25-g84398b9 to v1.3.0 TODO: - [x] Apply etcd [3.2 client upgrade guide](https://github.com/coreos/etcd/blob/master/Documentation/upgrades/upgrade_3_2.md) - [x] Apply grpc API changes in 1.6.0 and 1.7.0 [release notes](https://github.com/grpc/grpc-go/releases) - [x] bbolt was pulled in transitively, why? We have tests that embed etcd, so we must vendor the etcd server and all it's dependencies. - [x] Upgrade to containerd v1.0.0? Currently kubernetes depends on containerd v1.0.0-beta.2-159-g27d450a0 which depends on grpc v1.3.0, but containerd v1.0.0 depends on grpc 1.7.2. Not needed. The containerd grpc upgrade required [no code changes](containerd/containerd@ce3e326). - [x] Fix all failing tests - [x] Ensure we can safely upgrade grpc to 1.7.5 given that docker and cAdvisor still depend on grpc 1.3.0 (both in the versions we vend and on master for both projects). Should we hold off on this change until we have a docker release that uses gprc 1.7.x? - [x] Wait for grpc 1.7.5 to be released (it will include grpc/grpc-go#1747). Once released, bump grpc version in this PR and remove workarounds in `hack/godep-save.sh`. Transitive dependencies on grpc: - docker depends on grpc, but according to the package dependency graph (`go list -f '{{ .Deps }}'`) there are no dependencies from kubernetes to grpc via docker packages. - containerd v1.0.0 depends on grpc 1.7.2, we should upgrade to containerd v1.0.0 soon, this can be done in a separate PR - cadvisor depends on grpc 1.3.0 on master, it should upgrade it to grpc 1.7.5, this can be done in a separate PR **Release note**: ```release-note Upgrade to etcd client 3.2.11 and grpc 1.7.5 to improve HA etcd cluster stability. ``` Kubernetes-commit: a7b404ec7f7cbf153573b7b7e4b84267f36135d0
openshift-publish-robot
pushed a commit
to openshift/kubernetes-sample-apiserver
that referenced
this pull request
Jan 14, 2019
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Version bump to etcd v3.2.11, grpc v1.7.5 Fix kubernetes/kubernetes#56114: Update to etcd client 3.2.11 Version bumps: - etcd from 3.1.10 to 3.2.11 - grpc from 1.3.0 to 1.7.5 - grpc-gateway from v1.1.0-25-g84398b9 to v1.3.0 TODO: - [x] Apply etcd [3.2 client upgrade guide](https://github.com/coreos/etcd/blob/master/Documentation/upgrades/upgrade_3_2.md) - [x] Apply grpc API changes in 1.6.0 and 1.7.0 [release notes](https://github.com/grpc/grpc-go/releases) - [x] bbolt was pulled in transitively, why? We have tests that embed etcd, so we must vendor the etcd server and all it's dependencies. - [x] Upgrade to containerd v1.0.0? Currently kubernetes depends on containerd v1.0.0-beta.2-159-g27d450a0 which depends on grpc v1.3.0, but containerd v1.0.0 depends on grpc 1.7.2. Not needed. The containerd grpc upgrade required [no code changes](containerd/containerd@ce3e326). - [x] Fix all failing tests - [x] Ensure we can safely upgrade grpc to 1.7.5 given that docker and cAdvisor still depend on grpc 1.3.0 (both in the versions we vend and on master for both projects). Should we hold off on this change until we have a docker release that uses gprc 1.7.x? - [x] Wait for grpc 1.7.5 to be released (it will include grpc/grpc-go#1747). Once released, bump grpc version in this PR and remove workarounds in `hack/godep-save.sh`. Transitive dependencies on grpc: - docker depends on grpc, but according to the package dependency graph (`go list -f '{{ .Deps }}'`) there are no dependencies from kubernetes to grpc via docker packages. - containerd v1.0.0 depends on grpc 1.7.2, we should upgrade to containerd v1.0.0 soon, this can be done in a separate PR - cadvisor depends on grpc 1.3.0 on master, it should upgrade it to grpc 1.7.5, this can be done in a separate PR **Release note**: ```release-note Upgrade to etcd client 3.2.11 and grpc 1.7.5 to improve HA etcd cluster stability. ``` Kubernetes-commit: a7b404ec7f7cbf153573b7b7e4b84267f36135d0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1743