Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider export withContextDialer and deprecate WithDialer #2627

Closed
skipor opened this issue Feb 8, 2019 · 0 comments · Fixed by #2629
Closed

Consider export withContextDialer and deprecate WithDialer #2627

skipor opened this issue Feb 8, 2019 · 0 comments · Fixed by #2629
Assignees
@menghanl
Labels
Type: Feature New features or improvements in behavior

Comments

@skipor
Copy link

skipor commented Feb 8, 2019 •
edited
Loading

There is no way to get access to context.Context custom dialer for now.
Internally, withContextDialer everywhere, that's unfair to external users.
Related to #1786
@menghanl menghanl mentioned this issue Feb 8, 2019
Merged
@menghanl menghanl self-assigned this Feb 15, 2019
@menghanl menghanl added the Type: Feature New features or improvements in behavior label Feb 21, 2019
menghanl added a commit that referenced this issue Feb 25, 2019
@menghanl
dialOption: export WithContextDialer() (#2629)
40cb561 
fixes #2627
tac0turtle added a commit to tendermint/tendermint that referenced this issue Jul 23, 2019
@tac0turtle
Added statik to linter
955a51f 
- cleanup to add linter
- grpc change:
	- https://godoc.org/google.golang.org/grpc#WithContextDialer
	- https://godoc.org/google.golang.org/grpc#WithDialer
	- grpc/grpc-go#2627
- prometheous change:
	- due to UninstrumentedHandler, being deprecated in the future
- empty branch = empty if or else statement
	- didn't delete them entirely but commented
	- couldn't find a reason to have them
- could not replicate the issue #3406
	- but if want to keep it commented then we should comment out the if statement as well

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle mentioned this issue Jul 23, 2019
Merged
5 tasks
melekes pushed a commit to tendermint/tendermint that referenced this issue Jul 25, 2019
@tac0turtle @melekes
add staticcheck linting (#3828)
98cb8c9 
cleanup to add linter

    grpc change:
        https://godoc.org/google.golang.org/grpc#WithContextDialer
        https://godoc.org/google.golang.org/grpc#WithDialer
        grpc/grpc-go#2627
    prometheous change:
        due to UninstrumentedHandler, being deprecated in the future
    empty branch = empty if or else statement
        didn't delete them entirely but commented
        couldn't find a reason to have them
    could not replicate the issue #3406
        but if want to keep it commented then we should comment out the if statement as well
jackzampolin pushed a commit to tendermint/tendermint that referenced this issue Aug 1, 2019
@tac0turtle @jackzampolin
add staticcheck linting (#3828)
ff9e08a 
cleanup to add linter

    grpc change:
        https://godoc.org/google.golang.org/grpc#WithContextDialer
        https://godoc.org/google.golang.org/grpc#WithDialer
        grpc/grpc-go#2627
    prometheous change:
        due to UninstrumentedHandler, being deprecated in the future
    empty branch = empty if or else statement
        didn't delete them entirely but commented
        couldn't find a reason to have them
    could not replicate the issue #3406
        but if want to keep it commented then we should comment out the if statement as well
@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@menghanl menghanl

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dialOption: export WithContextDialer() menghanl/grpc-go
2 participants
@menghanl @skipor