-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server features should be []any, not []string #7932
Comments
It turns out Go's json umarshalling will result in an empty string instead of failing, so this may not be urgent. https://go.dev/play/p/T-Qa9ygkcsC Also, CC @ejona86 who says Java is (also?) decoding it as an array of strings, and @markdroth as FYI. |
It was clearly defined in gRFC A30. The relevant text was copied as a comment in the code. As discovered due to grpc/grpc-go#7932
It was clearly defined in gRFC A30. The relevant text was copied as a comment in the code. As discovered due to grpc/grpc-go#7932
It was clearly defined in gRFC A30. The relevant text was copied as a comment in the code. As discovered due to grpc/grpc-go#7932
It was clearly defined in gRFC A30. The relevant text was copied as a comment in the code. As discovered due to grpc/grpc-go#7932
It was clearly defined in gRFC A30. The relevant text was copied as a comment in the code. As discovered due to grpc/grpc-go#7932
I'm going to close this since we can just add support for non-string types (however that might work eventually) when we need them. We won't fail to parse newer configs that specify them with today's code. |
It was clearly defined in gRFC A30. The relevant text was copied as a comment in the code. As discovered due to grpc/grpc-go#7932
grpc-go/internal/xds/bootstrap/bootstrap.go
Line 272 in 317271b
Per A30:
(*'s added for emphasis)
We need to not fail to parse if other types are encountered here.
The text was updated successfully, but these errors were encountered: