Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate race on ac.acbw #1665

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Eliminate race on ac.acbw #1665

merged 1 commit into from
Nov 13, 2017

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Nov 10, 2017 •
edited
Loading

fixes #1662

This change is same as #1666 but against v1.7.x branch.

dfawley
dfawley approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start talking about keeping finer-grained locks at some point?

@gyuho gyuho mentioned this pull request Nov 11, 2017
Closed
@gyuho
Copy link
Contributor

gyuho commented Nov 13, 2017

Would this be released with v1.7.3 this week? Thanks!

@gyuho gyuho mentioned this pull request Nov 13, 2017
Merged
@menghanl menghanl mentioned this pull request Nov 13, 2017
Closed
@menghanl menghanl merged commit d4f3101 into grpc:v1.7.x Nov 13, 2017
@menghanl menghanl deleted the ac_mutex_17x branch November 13, 2017 21:44
@menghanl menghanl mentioned this pull request Nov 13, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@menghanl @gyuho @dfawley