Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix context import #2473

Closed
wants to merge 1 commit into from
Closed

fix context import #2473

wants to merge 1 commit into from

Conversation

dreambo8563
Copy link

cleanup: replace "x/net/context" import with "context" (#2439)

cleanup: replace "x/net/context" import with "context" (#2439)
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@dreambo8563
Copy link
Author

I signed it

@menghanl
Copy link
Contributor

This file is generated, and shouldn't be manually edited.
Also, if you use go1.9 and above, this shouldn't be a problem because "golang.org/x/net/context" is just a type alias.

The codegen change is already submitted upstream. We are waiting for a new release to update out dependencies.

@menghanl menghanl closed this Nov 29, 2018
@dreambo8563 dreambo8563 deleted the patch-1 branch November 30, 2018 01:27
@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants