Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: set auth header to localhost for unix target #3730

Merged
merged 13 commits into from
Jul 21, 2020
Merged

client: set auth header to localhost for unix target #3730

merged 13 commits into from
Jul 21, 2020

Conversation

GarrettGutierrez1
Copy link
Contributor

@GarrettGutierrez1 GarrettGutierrez1 commented Jul 7, 2020 •
edited by dfawley
Loading

Fixes #2628

Set authority header to "localhost" with a unix target string and added tests for unix targets that validate the authority header value.

easwars
easwars reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth putting the test in its own file. The end2end_test.go is way too big already and we try to move things out from time to time.

@GarrettGutierrez1
Copy link
Contributor Author

Might be worth putting the test in its own file. The end2end_test.go is way too big already and we try to move things out from time to time.

Moved the unix auth header tests to their own file.

@dfawley dfawley added this to the 1.31 Release milestone Jul 9, 2020
menghanl
menghanl suggested changes Jul 9, 2020
View reviewed changes
internal/grpcutil/target.go Outdated Show resolved Hide resolved
test/unix_test.go Outdated Show resolved Hide resolved
test/unix_test.go Outdated Show resolved Hide resolved
test/unix_test.go Outdated Show resolved Hide resolved
test/unix_test.go Outdated Show resolved Hide resolved
test/unix_test.go Outdated Show resolved Hide resolved
test/unix_test.go Outdated Show resolved Hide resolved
clientconn.go Outdated Show resolved Hide resolved
@menghanl menghanl mentioned this pull request Jul 9, 2020
Closed
menghanl
menghanl reviewed Jul 15, 2020
View reviewed changes
test/authority_test.go Outdated Show resolved Hide resolved
menghanl
menghanl reviewed Jul 17, 2020
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Some more comments on the stub server changes.

test/end2end_test.go Outdated Show resolved Hide resolved
test/end2end_test.go Outdated Show resolved Hide resolved
dfawley
dfawley reviewed Jul 17, 2020
View reviewed changes
test/end2end_test.go Outdated Show resolved Hide resolved
test/end2end_test.go Outdated Show resolved Hide resolved
test/end2end_test.go Show resolved Hide resolved
@menghanl menghanl changed the title Set auth header to localhost on unix target. client: set auth header to localhost for unix target. Jul 21, 2020
@menghanl menghanl changed the title client: set auth header to localhost for unix target. client: set auth header to localhost for unix target Jul 21, 2020
@menghanl menghanl merged commit a5a36bd into grpc:master Jul 21, 2020
@JamesNK JamesNK mentioned this pull request Aug 19, 2020
Closed
@gila gila mentioned this pull request Sep 15, 2020
Open
@saschagrunert saschagrunert mentioned this pull request Sep 15, 2020
Open
@edrevo edrevo mentioned this pull request Oct 7, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley left review comments

@easwars easwars easwars left review comments

@menghanl menghanl menghanl approved these changes

Assignees

@GarrettGutierrez1 GarrettGutierrez1

Labels
Type: Bug
Projects
None yet
Milestone
1.31 Release
Development

Successfully merging this pull request may close these issues.

authority header is set to empty string
4 participants
@GarrettGutierrez1 @menghanl @easwars @dfawley