balancer/base: keep address attributes for pickers #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
menghanl
added
the
Type: Behavior Change
menghanl
suggested changes
Mar 18, 2021
ok,I will add some tests |
|
@menghanl test cases added! |
menghanl
approved these changes
Mar 25, 2021
| t.Errorf("in picker.validate, got address %+v with nil attributes, want not nil", sc.Address) | ||
| } | ||
| foo, ok := sc.Address.Attributes.Value("foo").(string) | ||
| if !ok || foo != "2233niang" { |
menghanl
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4024 caused the Addresses.Attributes of readySCs obtained by pickerBuilder to be nil when regeneratePicker.
1.add subConnInfo struct which contains subConn and attributes.
2.add attributes to aNoAttrs when generate readySCs.
fixes #4276