interop: add a flag to clients to statically configure grpclb #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Mar 25, 2021
interop/client/client.go
Outdated
Comment on lines
188
to
189
| opts = append(opts, grpc.WithDisableServiceConfig()) | ||
| opts = append(opts, grpc.WithDefaultServiceConfig(*serviceConfigJSON)) |
There was a problem hiding this comment.
1-line:
opts = append(opts, grpc.WithDisableServiceConfig(), grpc.WithDefaultServiceConfig(*serviceConfigJSON))There was a problem hiding this comment.
done.
Thanks for the quick review. If this looks good, can you please merge? I don't have merge permissions on this repo (as noted in other PR)
dfawley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a go analogue of grpc/grpc-java#7957 - grpc/grpc-java#7957 (comment) for more context