authz: support empty principals and fix rbac authenticated matcher #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashithasantosh
commented
Oct 17, 2021
dfawley
reviewed
Oct 19, 2021
|
Could this see review soon, as it is holding up enabling RBAC in Go? |
dfawley
approved these changes
Oct 21, 2021
|
Thank you for the review, @dfawley!:) I resolved all the comments and even the tests passed. So merging the PR.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if we had empty principals in SDK policy, the translator would create RBAC policy with ANY rule for "Principal". With the changes in this PR, an empty principal in SDK policy will check for authenticated connection.
Similar behavior to unset principal_name in RBAC proto
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/rbac/v3/rbac.proto#config-rbac-v3-principal-authenticated
This PR also fixes rbac authenticated matcher, to check for TLS authenticated connection and correctly handle empty strings for TLS and plaintext case.
RELEASE NOTES: