xds/federation: e2e tests #5103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move func build resource name to testutils [xds_fed_e2e_tests] 111 [xds_fed_e2e_tests] magic!
easwars
reviewed
Jan 5, 2022
| "google.golang.org/grpc/xds/internal/xdsclient/xdsresource/version" | ||
| ) | ||
|
|
||
| func BuildResourceName(typ xdsresource.ResourceType, auth, id string, ctxParams map[string]string) string { |
There was a problem hiding this comment.
Needs a comment to make vet happy.
Comment on lines
50
to
54
| defer func() func() { | ||
| old := envconfig.XDSFederation | ||
| envconfig.XDSFederation = true | ||
| return func() { envconfig.XDSFederation = old } | ||
| }()() |
There was a problem hiding this comment.
This double func is super hard to read. Why do we need to do it this way?
| if err != nil { | ||
| t.Fatalf("Failed to create xDS resolver for testing: %v", err) | ||
| } | ||
| port, cleanup2 := clientSetup(t, &testService{}) |
There was a problem hiding this comment.
Nit: there is no var cleanup for this to be cleanup2
easwars
approved these changes
Jan 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moved func
BuildResourceNameto testutils to be sharedRELEASE NOTES: N/A