Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate all the duplicated testdata, allow running from any directory #545

Closed
wants to merge 1 commit into from

Conversation

bradfitz
Copy link
Contributor

  • Unify all the ca.pem, server1.key, server1.pem files into one testdata
    directory.
  • Add a function test.Abs() to return the absolute path of a file relative
    to the gRPC root. Use it from tests and examples.
  • Now examples can be run from any directory and still find their TLS
    or JSON input files.

…tory.

* Unify all the ca.pem, server1.key, server1.pem files into one testdata
  directory.
* Add a function test.Abs() to return the absolute path of a file relative
  to the gRPC root. Use it from tests and examples.
* Now examples can be run from any directory and still find their TLS
  or JSON input files.
@LetsUseGerrit
Copy link

Gerrit code review: https://go-review.googlesource.com/19436 (at git rev 60f2c4e)

@@ -31,7 +31,7 @@
*
*/

package grpc_test
package test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, would you mind moving this file up to the repo root and leaving it in package grpc_test? The current makeup of package test is confusing, where's it's half test utilities and half real tests.

@bradfitz
Copy link
Contributor Author

@iamqizhao, are you ready for this one if I update it to tip?

@dfawley dfawley added the TODO label Apr 28, 2017
@dfawley
Copy link
Member

dfawley commented May 19, 2017

@bradfitz if you are still interested in fixing this, we'd love to have it. Thanks!

@dfawley
Copy link
Member

dfawley commented Jun 23, 2017

#1297 is a newer attempt to fix this.

@dfawley dfawley closed this Jun 23, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants