Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/xdsclient: add EDS resource endpoint address duplication check #5715

Merged
merged 1 commit into from
Oct 12, 2022
Merged

xds/xdsclient: add EDS resource endpoint address duplication check #5715

merged 1 commit into from
Oct 12, 2022

Conversation

erni27
Copy link
Contributor

@erni27 erni27 commented Oct 12, 2022 •
edited by easwars
Loading

This PR adds a check if EDS resource contains a duplicate endpoint with the same address.

Fixes #5710

RELEASE NOTES:

  • xds: comply with recent change in xDS spec to NACK EDS resources with duplicate addresses

@erni27
Copy link
Contributor Author

erni27 commented Oct 12, 2022

Review-ready. @easwars

@easwars easwars added the Type: Behavior Change Behavior changes not categorized as bugs label Oct 12, 2022
@easwars easwars added this to the 1.51 Release milestone Oct 12, 2022
@easwars easwars requested a review from dfawley October 12, 2022 16:35
@easwars
Copy link
Contributor

easwars commented Oct 12, 2022

Thank you very much for PR, @erni27

@erni27
Copy link
Contributor Author

erni27 commented Oct 12, 2022

Probably not the best place to discuss but anyway. I'd like to dive deeper into grpc-go and help by contributing. I've searched through the open issues tagged Help wanted but some of them are really old and I don't know if they're still relevant and some of them seems to be assigned to someone / already resolved. Could you point me to the right direction? @easwars

@easwars
Copy link
Contributor

easwars commented Oct 12, 2022

Probably not the best place to discuss but anyway. I'd like to dive deeper into grpc-go and help by contributing. I've searched through the open issues tagged Help wanted but some of them are really old and I don't know if they're still relevant and some of them seems to be assigned to someone / already resolved. Could you point me to the right direction? @easwars

Yes, we haven't scrubbed through them in a while. I will take a look and ping you in a few issues, and you can pick up the ones you are interested in. Thanks for offering to contribute to our repo.

dfawley
dfawley approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@dfawley dfawley merged commit e163a90 into grpc:master Oct 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@easwars easwars easwars approved these changes

Assignees

@dfawley dfawley

Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Milestone
1.51 Release
Development

Successfully merging this pull request may close these issues.

xds: NACK EDS resources with duplicate addresses
3 participants
@erni27 @easwars @dfawley